Ensure that MavenPomDownloader's behavior around adding default repos…

…itories can be controlled from the execution context
openrewrite · Mar 27, 2024 · 152606f · 152606f
1 parent 12d0670
commit 152606f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/rewrite-maven/src/main/java/org/openrewrite/maven/MavenExecutionContextView.java b/rewrite-maven/src/main/java/org/openrewrite/maven/MavenExecutionContextView.java
@@ -45,6 +45,7 @@ public class MavenExecutionContextView extends DelegatingExecutionContext {
     private static final String MAVEN_POM_CACHE = "org.openrewrite.maven.pomCache";
     private static final String MAVEN_RESOLUTION_LISTENER = "org.openrewrite.maven.resolutionListener";
     private static final String MAVEN_RESOLUTION_TIME = "org.openrewrite.maven.resolutionTime";
+    private static final String IS_ENABLE_DEFAULT_REPOSITORIES = "org.openrewrite.maven.isEnableDefaultRepositories";
 
     public MavenExecutionContextView(ExecutionContext delegate) {
         super(delegate);
@@ -211,6 +212,16 @@ public MavenSettings getSettings() {
         return getMessage(MAVEN_SETTINGS, null);
     }
 
+    @Nullable
+    public Boolean isEnableDefaultRepositories() {
+        return getMessage(IS_ENABLE_DEFAULT_REPOSITORIES, null);
+    }
+
+    public MavenExecutionContextView setEnableDefaultRepositories(@Nullable Boolean enableDefaultRepositories) {
+        putMessage(IS_ENABLE_DEFAULT_REPOSITORIES, enableDefaultRepositories);
+        return this;
+    }
+
     private static List<String> mapActiveProfiles(MavenSettings settings, String... activeProfiles) {
         if(settings.getActiveProfiles() == null) {
             return Arrays.asList(activeProfiles);

diff --git a/rewrite-maven/src/main/java/org/openrewrite/maven/internal/MavenPomDownloader.java b/rewrite-maven/src/main/java/org/openrewrite/maven/internal/MavenPomDownloader.java
@@ -97,6 +97,8 @@ public MavenPomDownloader(Map<Path, Pom> projectPoms, ExecutionContext ctx,
         this(projectPoms, HttpSenderExecutionContextView.view(ctx).getHttpSender(), ctx);
         this.mavenSettings = mavenSettings;
         this.activeProfiles = activeProfiles;
+        Boolean enableDefaultRepositories = MavenExecutionContextView.view(ctx).isEnableDefaultRepositories();
+        this.addDefaultRepositories = enableDefaultRepositories == null || enableDefaultRepositories;
     }
 
     /**
@@ -108,7 +110,8 @@ public MavenPomDownloader(Map<Path, Pom> projectPoms, ExecutionContext ctx,
      */
     public MavenPomDownloader(ExecutionContext ctx) {
         this(emptyMap(), HttpSenderExecutionContextView.view(ctx).getHttpSender(), ctx);
-        this.addDefaultRepositories = false;
+        Boolean enableDefaultRepositories = MavenExecutionContextView.view(ctx).isEnableDefaultRepositories();
+        this.addDefaultRepositories = enableDefaultRepositories != null && enableDefaultRepositories;
     }
 
     /**
@@ -249,7 +252,7 @@ public MavenMetadata downloadMetadata(GroupArtifactVersion gav, @Nullable Resolv
                 try {
                     String scheme = URI.create(repo.getUri()).getScheme();
                     String uri = repo.getUri() + (repo.getUri().endsWith("/") ? "" : "/") +
-                                 gav.getGroupId().replace('.', '/') + '/' +
+                                 requireNonNull(gav.getGroupId()).replace('.', '/') + '/' +
                                  gav.getArtifactId() + '/' +
                                  (gav.getVersion() == null ? "" : gav.getVersion() + '/') +
                                  "maven-metadata.xml";