Normalize server URLs to avoid missing scheme #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the output slightly (no more user in the URL) but that is fine as the user is not required/used in matching anyway. Also fixed the comment and exception text.
| GitLab, scm.company.com/context/gitlab, group/subgroup/repo, https, https://scm.company.com/context/gitlab/group/subgroup/repo.git | ||
| GitLab, scm.company.com:8443/context/gitlab, group/subgroup/repo, https, https://scm.company.com:8443/context/gitlab/group/subgroup/repo.git | ||
| GitLab, scm.company.com/context/gitlab, group/subgroup/repo, ssh, ssh://[email protected]:8022/context/gitlab/group/subgroup/repo.git |
There was a problem hiding this comment.
Can you confirm this will not cause problem when trying to close using ssh?
There was a problem hiding this comment.
Hmm, thinking some more on it maybe this can cause problems if a local env requires it to match the right user/pw
There was a problem hiding this comment.
reverted and changed to normalize on the fly during protocol matching
bryceatmoderne
approved these changes
Dec 12, 2024
pstreef
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the output slightly (no more user in the URL) but that is fine as the user is not required/used in matching anyway.
Also fixed the comment and exception text.