Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteArchive SearchResult is not printed #4790

Closed
wants to merge 1 commit into from

Conversation

pstreef
Copy link
Contributor

@pstreef pstreef commented Dec 16, 2024

This adds a test demonstrating that RemoteArchive printing does not add the search marker.

This adds a test demonstrating that RemoteArchive printing does not add the search marker.
@timtebeek timtebeek added the bug Something isn't working label Dec 22, 2024
@sambsnyd
Copy link
Member

A RemoteArchive representing a binary file would have no sensible way to print a marker.
A RemoteArchive represents a test file I agree it makes sense to print the marker same as you would a PlainText.
It is straightforward assert the presence of the marker without printing.
So I don't see a lot of value in adding a printer for this, but I wont object so long as that printer is part of the test harness.

@pstreef
Copy link
Contributor Author

pstreef commented Dec 23, 2024

After some discussion we decided to leave this as is for now.

@pstreef pstreef closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants