Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[maven]: update plugin dependencies #4798

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix[maven]: update plugin dependencies #4798

merged 2 commits into from
Dec 18, 2024

Conversation

jonblack
Copy link
Contributor

@jonblack jonblack commented Dec 18, 2024 •
edited by timtebeek
Loading

What's changed?

Adds a unit test for the ChangeDependencyGroupIdAndArtifactId recipe to update plugin dependencies. The fix is not provided.

@timtebeek timtebeek marked this pull request as draft December 18, 2024 15:29
@timtebeek timtebeek self-requested a review December 18, 2024 15:34
@timtebeek timtebeek added the enhancement New feature or request label Dec 18, 2024
@timtebeek timtebeek marked this pull request as ready for review December 18, 2024 22:17
timtebeek
timtebeek approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the test @jonblack ; that made this easy to verify & fix.

@timtebeek timtebeek merged commit 6b2b63c into openrewrite:main Dec 18, 2024
2 checks passed
@timtebeek timtebeek mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@jonblack jonblack

Labels
enhancement New feature or request
Projects
OpenRewrite
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependencies of plugins are not updated
2 participants
@jonblack @timtebeek