Support mapping of generic thrown exception types #4813
Merged
+80
−151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Widened the type of
JavaType.Method#thrownExceptions
toJavaType
to support the mapping of generic exceptions.A method that throws a combination of a generic and non-generic exception looks like this:
Its JVMS 4.3.4 signature is:
What's your motivation?
Preparing the way for compile verification as a post-recipe task.
Anything in particular you'd like reviewers to focus on?
Should be LST deserialization compatible, but this is an ABI change and we should release workers and CLI ASAP. Old serialized LSTs will not have mapped generic exceptions correctly. They instead previously mapped the class bound (in the example above
java.io.FileNotFoundException
.Checklist