Skip to content

Commit

Permalink
Workflow benchmark-pull-request.yml fix (#16925)
Browse files Browse the repository at this point in the history
Signed-off-by: Prudhvi Godithi <[email protected]>
  • Loading branch information
prudhvigodithi authored Jan 2, 2025
1 parent ab546ae commit 542b551
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions .github/workflows/benchmark-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ on:
types: [created]
jobs:
run-performance-benchmark-on-pull-request:
if: ${{ (github.event.issue.pull_request) && (contains(github.event.comment.body, '"run-benchmark-test"')) }}
if: |
github.repository == 'opensearch-project/OpenSearch' &&
github.event.issue.pull_request &&
contains(github.event.comment.body, '"run-benchmark-test"')
runs-on: ubuntu-latest
permissions:
id-token: write
Expand Down Expand Up @@ -111,7 +114,7 @@ jobs:
uses: actions/github-script@v7
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
result-encoding: string
result-encoding: json
script: |
// Get the collaborators - filtered to maintainer permissions
const maintainersResponse = await github.request('GET /repos/{owner}/{repo}/collaborators', {
Expand All @@ -121,12 +124,12 @@ jobs:
affiliation: 'all',
per_page: 100
});
return maintainersResponse.data.map(item => item.login).join(', ');
return maintainersResponse.data.map(item => item.login);
- uses: trstringer/manual-approval@v1
if: (!contains(steps.get_approvers.outputs.result, github.event.comment.user.login))
if: ${{ !contains(fromJSON(steps.get_approvers.outputs.result), github.event.comment.user.login) }}
with:
secret: ${{ github.TOKEN }}
approvers: ${{ steps.get_approvers.outputs.result }}
approvers: ${{ join(fromJSON(steps.get_approvers.outputs.result), ', ') }}
minimum-approvals: 1
issue-title: 'Request to approve/deny benchmark run for PR #${{ env.PR_NUMBER }}'
issue-body: "Please approve or deny the benchmark run for PR #${{ env.PR_NUMBER }}"
Expand Down

0 comments on commit 542b551

Please sign in to comment.