Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled auto_expand_replicas setting when search replica is enabled #16916

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vinaykpud
Copy link
Contributor

@vinaykpud vinaykpud commented Dec 28, 2024

Description

In this PR we are disabling the auto_expand_replicas when the search replica is active. So this adds the mutual exclusiveness between the index.auto_expand_replicas and index.number_of_search_only_replicas settings.

Related Issues

Resolves #16912
Related to #15306

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for c6a1d64: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for c6a1d64: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b985309: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 03ea0e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vinaykpud vinaykpud closed this Jan 1, 2025
@vinaykpud vinaykpud reopened this Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

❕ Gradle check result for 03ea0e9: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.15%. Comparing base (ab546ae) to head (5ae03df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16916      +/-   ##
============================================
- Coverage     72.23%   72.15%   -0.09%     
+ Complexity    65210    65184      -26     
============================================
  Files          5299     5299              
  Lines        303475   303499      +24     
  Branches      43925    43933       +8     
============================================
- Hits         219217   218976     -241     
- Misses        66254    66527     +273     
+ Partials      18004    17996       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
@github-actions github-actions bot added Roadmap:Search Project-wide roadmap label v2.19.0 Issues and PRs related to version 2.19.0 labels Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

✅ Gradle check result for 5ae03df: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Roadmap:Search Project-wide roadmap label Search:Performance v2.19.0 Issues and PRs related to version 2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RW Separation] Disable auto-expand-replica case with search replicas
1 participant