Update script supports java.lang.String.sha1() and java.lang.String.sha256() methods #16923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ha256() methods Signed-off-by: Gao Binlong <[email protected]>
gaobinlong
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16923 +/- ##
============================================
- Coverage 72.28% 72.21% -0.07%
+ Complexity 65238 65224 -14
============================================
Files 5297 5299 +2
Lines 303351 303475 +124
Branches 43918 43925 +7
============================================
- Hits 219279 219159 -120
- Misses 66120 66351 +231
- Partials 17952 17965 +13 ☔ View full report in Codecov by Sentry. |
reta
reviewed
Dec 31, 2024
reta
added
v3.0.0
Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: Gao Binlong <[email protected]>
|
❌ Gradle check result for c016747: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for c016747: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
approved these changes
Jan 2, 2025
|
❌ Gradle check result for c016747: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
…ha256() methods (#16923) * Update script supports java.lang.String.sha1() and java.lang.String.sha256() methods Signed-off-by: Gao Binlong <[email protected]> * Modify change log Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> (cherry picked from commit ab546ae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
added a commit
that referenced
this pull request
Jan 2, 2025
…a.lang.String.sha256() methods (#16931) * Update script supports java.lang.String.sha1() and java.lang.String.sha256() methods (#16923) * Update script supports java.lang.String.sha1() and java.lang.String.sha256() methods Signed-off-by: Gao Binlong <[email protected]> * Modify change log Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> (cherry picked from commit ab546ae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update PainlessPlugin.java (use Whitelist instead of AllowList) Signed-off-by: Andriy Redko <[email protected]> * Update PainlessPlugin.java Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now we have augmentation methods
sha1andsha256for strings in painless script:OpenSearch/modules/lang-painless/src/main/java/org/opensearch/painless/api/Augmentation.java
Line 687 in 7ae66d0
, but it can only be used in ingest context for use in ingest pipeline, we can expand the scope to the update context so that these methods can be used in operations like update document, reindex and update_by_query.
Related Issues
#16423
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.