Adding feature direction and moving suppression rules to each feature

[amitgalitz]

Description

• Added feature direction capability to each feature so users can select if anomalies should only be considered if they actual values goes either above or below the expected value.
• Moved suppressionRules into the feature creation and redesigned it,
• Fixed a bug when we had multiple rules with negative values where the toast message was blank.
• Additional slight wording changes on different form fields

Check List

• New functionality includes testing.
  • All tests pass
• [] New functionality has been documented.
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[kaituo]

I manually tested your code and found two issues.

First, I tested bwc by creating a detector using cli. By default, every feature has two rules like

"rules": [
            {
                "action": "IGNORE_ANOMALY",
                "conditions": [
                    {
                        "feature_name": "deny max",
                        "threshold_type": "ACTUAL_OVER_EXPECTED_RATIO",
                        "operator": "LTE",
                        "value": 0.2
                    },
                    {
                        "feature_name": "deny max",
                        "threshold_type": "EXPECTED_OVER_ACTUAL_RATIO",
                        "operator": "LTE",
                        "value": 0.2
                    }
                ]
            }
        ]

But when I open the detector from UI, I can see only one rule:

Second, I am expecting that I cannot define a suppression rule from the opposite direction a user has selected. For example, when I select "Rise above expected value", I should not be able to see the "below the expected value" from the rule section. But I do see it:

[amitgalitz]

I will address these issue, in addition, I missed on the part with the default rules, I will make sure we show them correctly in UI and also now for every detector with a feature direction we will have just that one default rule show along with the change on the UI so selection for only one shows.

[kaituo]

A few thoughts.

First, for every detector with a feature direction we will have just that two identical default rules show along with the change.

Second, current UX will overwrite my rules when I am playing around directions. For example, my double direction rules will not come back once I re-select "Deviation in any direction". Before cx click save, you have the original rules in record. You can restore them back, right?

Third, is it a good experience to change customers' rules when I change direction? For example, original rules are "above".

When I change to "below", both rules changed to "below":

Should we just hide the "above" rules?