-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump BWC Version to 2.18 and Fix Bugs #1311
Conversation
This PR includes the following updates and bug fixes: * Bump BWC Version to 2.18: Updated BWC version to 2.18 since the 2.17 branch has been cut. * Fix Confidence Value Exceeding 1 in RCF: Addressed a bug in RCF where the confidence value could exceed 1. Implemented a check to cap the confidence value at 1, preventing invalid confidence scores. * Correct Parameter Assignment in GetAnomalyDetectorTransportAction: Fixed an issue where parameter assignments within a method did not affect external variables due to Java's pass-by-value nature. * Fixed a bug in ResultProcessor where we were supposed to check whether the number of sent messages equals the number of received messages before starting imputation. However, the sent message count was mistakenly based on the number of pages rather than the actual number of messages. * Fixed a bug where we mistakenly used the total reserved memory bytes as the memory size per entity in PriorityCache. Testing done: * added test cases for the buggy scenarios * manual e2e testing Signed-off-by: Kaituo Li <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
============================================
+ Coverage 71.83% 77.52% +5.69%
- Complexity 4898 5456 +558
============================================
Files 518 533 +15
Lines 22879 23333 +454
Branches 2245 2311 +66
============================================
+ Hits 16434 18088 +1654
+ Misses 5410 4184 -1226
- Partials 1035 1061 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/anomaly-detection/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/anomaly-detection/backport-2.x
# Create a new branch
git switch --create backport/backport-1311-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dbf8785e0718c5e6304729818e05bef64f30987c
# Push it to GitHub
git push --set-upstream origin backport/backport-1311-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/anomaly-detection/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/anomaly-detection/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/anomaly-detection/backport-2.17
# Create a new branch
git switch --create backport/backport-1311-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dbf8785e0718c5e6304729818e05bef64f30987c
# Push it to GitHub
git push --set-upstream origin backport/backport-1311-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/anomaly-detection/backport-2.17 Then, create a pull request where the |
This PR includes the following updates and bug fixes: * Bump BWC Version to 2.18: Updated BWC version to 2.18 since the 2.17 branch has been cut. * Fix Confidence Value Exceeding 1 in RCF: Addressed a bug in RCF where the confidence value could exceed 1. Implemented a check to cap the confidence value at 1, preventing invalid confidence scores. * Correct Parameter Assignment in GetAnomalyDetectorTransportAction: Fixed an issue where parameter assignments within a method did not affect external variables due to Java's pass-by-value nature. * Fixed a bug in ResultProcessor where we were supposed to check whether the number of sent messages equals the number of received messages before starting imputation. However, the sent message count was mistakenly based on the number of pages rather than the actual number of messages. * Fixed a bug where we mistakenly used the total reserved memory bytes as the memory size per entity in PriorityCache. Testing done: * added test cases for the buggy scenarios * manual e2e testing Signed-off-by: Kaituo Li <[email protected]>
This PR includes the following updates and bug fixes: * Bump BWC Version to 2.18: Updated BWC version to 2.18 since the 2.17 branch has been cut. * Fix Confidence Value Exceeding 1 in RCF: Addressed a bug in RCF where the confidence value could exceed 1. Implemented a check to cap the confidence value at 1, preventing invalid confidence scores. * Correct Parameter Assignment in GetAnomalyDetectorTransportAction: Fixed an issue where parameter assignments within a method did not affect external variables due to Java's pass-by-value nature. * Fixed a bug in ResultProcessor where we were supposed to check whether the number of sent messages equals the number of received messages before starting imputation. However, the sent message count was mistakenly based on the number of pages rather than the actual number of messages. * Fixed a bug where we mistakenly used the total reserved memory bytes as the memory size per entity in PriorityCache. Testing done: * added test cases for the buggy scenarios * manual e2e testing Signed-off-by: Kaituo Li <[email protected]>
This PR includes the following updates and bug fixes: * Bump BWC Version to 2.18: Updated BWC version to 2.18 since the 2.17 branch has been cut. * Fix Confidence Value Exceeding 1 in RCF: Addressed a bug in RCF where the confidence value could exceed 1. Implemented a check to cap the confidence value at 1, preventing invalid confidence scores. * Correct Parameter Assignment in GetAnomalyDetectorTransportAction: Fixed an issue where parameter assignments within a method did not affect external variables due to Java's pass-by-value nature. * Fixed a bug in ResultProcessor where we were supposed to check whether the number of sent messages equals the number of received messages before starting imputation. However, the sent message count was mistakenly based on the number of pages rather than the actual number of messages. * Fixed a bug where we mistakenly used the total reserved memory bytes as the memory size per entity in PriorityCache. Testing done: * added test cases for the buggy scenarios * manual e2e testing Signed-off-by: Kaituo Li <[email protected]>
This PR includes the following updates and bug fixes: * Bump BWC Version to 2.18: Updated BWC version to 2.18 since the 2.17 branch has been cut. * Fix Confidence Value Exceeding 1 in RCF: Addressed a bug in RCF where the confidence value could exceed 1. Implemented a check to cap the confidence value at 1, preventing invalid confidence scores. * Correct Parameter Assignment in GetAnomalyDetectorTransportAction: Fixed an issue where parameter assignments within a method did not affect external variables due to Java's pass-by-value nature. * Fixed a bug in ResultProcessor where we were supposed to check whether the number of sent messages equals the number of received messages before starting imputation. However, the sent message count was mistakenly based on the number of pages rather than the actual number of messages. * Fixed a bug where we mistakenly used the total reserved memory bytes as the memory size per entity in PriorityCache. Testing done: * added test cases for the buggy scenarios * manual e2e testing Signed-off-by: Kaituo Li <[email protected]>
Description
This PR includes the following updates and bug fixes:
Testing done:
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.