Added undefined check to event action #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshien
requested review from
getsaurabh02,
peterzhuamazon,
gaiksaya,
prudhvigodithi and
nhtruong
as code owners
bshien
force-pushed
the
action-undef-check
branch
from
d6e06e4 to
29e7502
Compare
Signed-off-by: Brandon Shien <[email protected]>
bshien
force-pushed
the
action-undef-check
branch
from
29e7502 to
a9c90c8
Compare
bshien
force-pushed
the
action-undef-check
branch
2 times, most recently
from
6e366a1 to
5863668
Compare
…o tests Signed-off-by: Brandon Shien <[email protected]>
bshien
force-pushed
the
action-undef-check
branch
from
5863668 to
d65102d
Compare
peterzhuamazon
approved these changes
Oct 10, 2024
peterzhuamazon
force-pushed
the
action-undef-check
branch
from
38838b6 to
6033fd1
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Seems like the version bump checking is not correct. |
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added undefined check to event action to prevent events without actions from being named as
eventName.undefinedIssues Resolved
Part of opensearch-project/opensearch-metrics#76
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.