ManagedIndex Explain Action - Index permissions check fix #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petardz
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong and
Hailong-am
as code owners
Codecov Report
@@ Coverage Diff @@
## main #783 +/- ##
============================================
+ Coverage 75.53% 75.63% +0.10%
- Complexity 2831 2833 +2
============================================
Files 364 364
Lines 16176 16177 +1
Branches 2324 2324
============================================
+ Hits 12219 12236 +17
+ Misses 2619 2603 -16
Partials 1338 1338
|
| @@ -180,83 +182,81 @@ class TransportExplainAction @Inject constructor( | |||
| } | |||
|
|
|||
| private fun searchForMetadata(searchRequest: SearchRequest) { | |||
| client.threadPool().threadContext.stashContext().use { threadContext -> | |||
There was a problem hiding this comment.
Stash context so that plugin can search the ISM system index, otherwise the search won't return anything
There was a problem hiding this comment.
this is called from coroutine so TLS should be clean at this point
...arch/indexmanagement/indexstatemanagement/transport/action/explain/TransportExplainAction.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/opensearch/indexmanagement/ExplainSecurityBehaviorIT.kt
Outdated
Show resolved
Hide resolved
petardz
force-pushed
the
explain-index-check-fix
branch
from
d80fcd1 to
7f73a2c
Compare
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
…urity tests into security package Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
…roject#722) * notification crud api Signed-off-by: zhichao-aws <[email protected]> * changes based on comments; add tests Signed-off-by: zhichao-aws <[email protected]> * changes for comment Signed-off-by: zhichao-aws <[email protected]> * change behavior for get action index not exists, fix test cases Signed-off-by: zhichao-aws <[email protected]> * fix weak password for changes in security plugin Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]>
…urity tests into security package Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
petardz
force-pushed
the
explain-index-check-fix
branch
2 times, most recently
from
4b7d6a2 to
95d4c8c
Compare
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixed verifying index permissions when calling Explain API on managed index
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.