fix post_process_function bug on sort results for rerank_pipeline_with_bge-rerank-m3-v2_model_deployed_on_Sagemaker.md #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkykenmt
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
tkykenmt
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
tkykenmt
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
…n recieve empty result from a model. Signed-off-by: tkykenmt <[email protected]>
tkykenmt
force-pushed
the
patch.tutorial-rerank-bge-rerank-m3-v2
branch
from
91abc83 to
093fed8
Compare
tkykenmt
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
tkykenmt
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
5 tasks
tkykenmt
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
mingshl
reviewed
Dec 16, 2024
| { | ||
| "index": 3, | ||
| "score": 0.00012148176 | ||
| } | ||
| ] | ||
| ``` | ||
|
|
||
| The connector `post_process_function` transforms the model's output into a format that the [Reranker processor](https://opensearch.org/docs/latest/search-plugins/search-pipelines/rerank-processor/) can interpret. This adapted format is as follows: | ||
| The connector `post_process_function` transforms the model's output into a format that the [Reranker processor](https://opensearch.org/docs/latest/search-plugins/search-pipelines/rerank-processor/) can interpretm, and order result by index. This adapted format is as follows: |
There was a problem hiding this comment.
Nit, interpretm should be interpret?
There was a problem hiding this comment.
Thank you for review. I fixed it on fixed up commit.
tkykenmt
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
tkykenmt
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
tkykenmt
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
…-project#3260) This PR addresses the first part of this enhancement "Validate if connector payload has all the required fields. If not provided, throw the illegal argument exception". Validation of fields description, parameters, credential, and request_body are missing. That validations are added in this fix. Added new test cases correspong to these validations and fixed all failing test cases because of these new validations. Partially Resolves opensearch-project#1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
…oject#3282) Modify getMemory(Conversation) to return the application_type parameter. Include application_type in the ConversationMeta data model. Update existing tests to validate the new parameter. Signed-off-by: rithin-pullela-aws <[email protected]>
…ject#3283) * Enchance Message and Memory API Validation and storage Throw an error when an unknown field is provided in CreateConversation or CreateInteraction. Skip saving empty fields in interactions and conversations to optimize storage usage. Modify GET requests for interactions and conversations to return only non-null fields. Throw an exception if all fields in a create interaction call are empty or null. Add unit tests to cover the above cases. Signed-off-by: rithin-pullela-aws <[email protected]> * Update unit test to check for null instead of empty map Signed-off-by: rithin-pullela-aws <[email protected]> * Refactored userstr to Camel Case Signed-off-by: rithin-pullela-aws <[email protected]> * Addressing comments Used assertThrows and added promptTemplate with empty string in test_ToXContent to ensure well rounded testing of expected functionality Signed-off-by: rithin-pullela-aws <[email protected]> * Undo: throw an error when an unknown field is provided in CreateConversation or CreateInteraction. Signed-off-by: rithin-pullela-aws <[email protected]> --------- Signed-off-by: rithin-pullela-aws <[email protected]>
…function recieve empty result from a model. Signed-off-by: tkykenmt <[email protected]>
…ub.com/tkykenmt/ml-commons into patch.tutorial-rerank-bge-rerank-m3-v2
tkykenmt
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
tkykenmt
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
|
close to move to #3296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n recieve empty result from a model.
Description
fix post_process_function bug on sort results for docs/tutorials/rerank/rerank_pipeline_with_bge-rerank-m3-v2_model_deployed_on_Sagemaker.md
Related Issues
Resolves #3247
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.