Adding backwards compatibility test for ml-commons plugin #681

b4sjoo · 2023-01-10T01:01:55Z

Signed-off-by: Sicheng Song [email protected]

Description

This PR should add backwards compatibility test for our ml-commons plugin in order to test the backwards compatibility of the latest minor version of the previous major version of our plugin.

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sicheng Song <[email protected]>

codecov-commenter · 2023-01-10T01:10:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.31%. Comparing base (04d6864) to head (9d68f73).
Report is 609 commits behind head on 2.x.

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x     #681      +/-   ##
============================================
- Coverage     84.18%   83.31%   -0.87%     
+ Complexity     1010      994      -16     
============================================
  Files            93       93              
  Lines          3660     3662       +2     
  Branches        342      343       +1     
============================================
- Hits           3081     3051      -30     
- Misses          435      464      +29     
- Partials        144      147       +3

Flag	Coverage Δ
ml-commons	`83.31% <ø> (-0.87%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sicheng Song <[email protected]>

ylwu-amzn · 2023-01-10T17:45:24Z

.gitignore

@@ -5,4 +5,5 @@ client/build/
 common/build/
 ml-algorithms/build/
 plugin/build/
+plugin/src/test/resources/bwc/*


Anywhere else using this path pattern? I don't see this in other places.

This path is for storing the downloaded old and updated version of ml-commons plugins used in bwc test

ylwu-amzn · 2023-01-10T17:56:09Z

plugin/build.gradle

@@ -369,3 +369,166 @@ tasks.withType(licenseHeaders.class) {
 checkstyle {
    toolVersion = '8.29'
 }
+
+String bwcVersion = "1.3.0.0"


Add how to run bwc test to developer guide like AD https://github.com/opensearch-project/anomaly-detection/blob/main/DEVELOPER_GUIDE.md

ylwu-amzn · 2023-01-10T17:59:14Z

I think we should add Github workflow file like AD https://github.com/opensearch-project/anomaly-detection/blob/main/.github/workflows/test_bwc.yml. So for any PR or code push, it will trigger bwc test automatically.

Signed-off-by: Sicheng Song <[email protected]>

… task bwcsuite or its dependent tasks Signed-off-by: Sicheng Song <[email protected]>

Signed-off-by: Sicheng Song <[email protected]>

* Adding backwards compatibility test for ml-commons plugin Signed-off-by: Sicheng Song <[email protected]> * Adjust gradle build file to create bwc tasks Signed-off-by: Sicheng Song <[email protected]> * Add bwc test to CI workflow and developer guide Signed-off-by: Sicheng Song <[email protected]> * Add gradle test filter so BWC test can only run within the BWC gradle task bwcsuite or its dependent tasks Signed-off-by: Sicheng Song <[email protected]> * bug fix for bwc test Signed-off-by: Sicheng Song <[email protected]> * Fix running on ml node issue Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Sicheng Song <[email protected]> (cherry picked from commit e37ab93)

…-project#681) * Adding backwards compatibility test for ml-commons plugin Signed-off-by: Sicheng Song <[email protected]> * Adjust gradle build file to create bwc tasks Signed-off-by: Sicheng Song <[email protected]> * Add bwc test to CI workflow and developer guide Signed-off-by: Sicheng Song <[email protected]> * Add gradle test filter so BWC test can only run within the BWC gradle task bwcsuite or its dependent tasks Signed-off-by: Sicheng Song <[email protected]> * bug fix for bwc test Signed-off-by: Sicheng Song <[email protected]> * Fix running on ml node issue Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Sicheng Song <[email protected]>

* Adding backwards compatibility test for ml-commons plugin Signed-off-by: Sicheng Song <[email protected]> * Adjust gradle build file to create bwc tasks Signed-off-by: Sicheng Song <[email protected]> * Add bwc test to CI workflow and developer guide Signed-off-by: Sicheng Song <[email protected]> * Add gradle test filter so BWC test can only run within the BWC gradle task bwcsuite or its dependent tasks Signed-off-by: Sicheng Song <[email protected]> * bug fix for bwc test Signed-off-by: Sicheng Song <[email protected]> * Fix running on ml node issue Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Sicheng Song <[email protected]>

…-project#681) * Adding backwards compatibility test for ml-commons plugin Signed-off-by: Sicheng Song <[email protected]> * Adjust gradle build file to create bwc tasks Signed-off-by: Sicheng Song <[email protected]> * Add bwc test to CI workflow and developer guide Signed-off-by: Sicheng Song <[email protected]> * Add gradle test filter so BWC test can only run within the BWC gradle task bwcsuite or its dependent tasks Signed-off-by: Sicheng Song <[email protected]> * bug fix for bwc test Signed-off-by: Sicheng Song <[email protected]> * Fix running on ml node issue Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Sicheng Song <[email protected]>

…-project#681) * Adding backwards compatibility test for ml-commons plugin Signed-off-by: Sicheng Song <[email protected]> * Adjust gradle build file to create bwc tasks Signed-off-by: Sicheng Song <[email protected]> * Add bwc test to CI workflow and developer guide Signed-off-by: Sicheng Song <[email protected]> * Add gradle test filter so BWC test can only run within the BWC gradle task bwcsuite or its dependent tasks Signed-off-by: Sicheng Song <[email protected]> * bug fix for bwc test Signed-off-by: Sicheng Song <[email protected]> * Fix running on ml node issue Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Yaliang Wu <[email protected]>

Issue: - In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails. - Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076). - Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception. Resolution: - Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline. - [Cross-Cluster Replication PR opensearch-project#469](opensearch-project/cross-cluster-replication#469) - [Security PR #2253](opensearch-project/security#2253) - [ML Commons PR opensearch-project#681](opensearch-project/ml-commons#681) - Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10. Testing: - Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed. Signed-off-by: Kaituo Li <[email protected]>

…sue (#1029) Issue: - In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails. - Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076). - Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception. Resolution: - Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline. - [Cross-Cluster Replication PR #469](opensearch-project/cross-cluster-replication#469) - [Security PR #2253](opensearch-project/security#2253) - [ML Commons PR #681](opensearch-project/ml-commons#681) - Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10. Testing: - Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed. Signed-off-by: Kaituo Li <[email protected]>

…sue (#1029) Issue: - In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails. - Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076). - Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception. Resolution: - Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline. - [Cross-Cluster Replication PR #469](opensearch-project/cross-cluster-replication#469) - [Security PR #2253](opensearch-project/security#2253) - [ML Commons PR #681](opensearch-project/ml-commons#681) - Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10. Testing: - Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 3c1a830)

…sue (#1029) (#1030) Issue: - In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails. - Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076). - Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception. Resolution: - Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline. - [Cross-Cluster Replication PR #469](opensearch-project/cross-cluster-replication#469) - [Security PR #2253](opensearch-project/security#2253) - [ML Commons PR #681](opensearch-project/ml-commons#681) - Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10. Testing: - Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 3c1a830) Co-authored-by: Kaituo Li <[email protected]>

* Adding backwards compatibility test for ml-commons plugin Signed-off-by: Sicheng Song <[email protected]> * Adjust gradle build file to create bwc tasks Signed-off-by: Sicheng Song <[email protected]> * Add bwc test to CI workflow and developer guide Signed-off-by: Sicheng Song <[email protected]> * Add gradle test filter so BWC test can only run within the BWC gradle task bwcsuite or its dependent tasks Signed-off-by: Sicheng Song <[email protected]> * bug fix for bwc test Signed-off-by: Sicheng Song <[email protected]> * Fix running on ml node issue Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Sicheng Song <[email protected]> (cherry picked from commit e37ab93)

Adding backwards compatibility test for ml-commons plugin

219d5fe

Signed-off-by: Sicheng Song <[email protected]>

b4sjoo requested a review from a team January 10, 2023 01:01

Adjust gradle build file to create bwc tasks

15cfb65

Signed-off-by: Sicheng Song <[email protected]>

b4sjoo requested a review from ylwu-amzn January 10, 2023 01:55

ylwu-amzn reviewed Jan 10, 2023

View reviewed changes

b4sjoo added 4 commits January 10, 2023 19:00

Add bwc test to CI workflow and developer guide

cf310b5

Signed-off-by: Sicheng Song <[email protected]>

Add gradle test filter so BWC test can only run within the BWC gradle…

943c833

… task bwcsuite or its dependent tasks Signed-off-by: Sicheng Song <[email protected]>

bug fix for bwc test

7c35660

Signed-off-by: Sicheng Song <[email protected]>

Fix running on ml node issue

9d68f73

Signed-off-by: Sicheng Song <[email protected]>

b4sjoo requested a review from ylwu-amzn January 11, 2023 00:46

rbhavna approved these changes Jan 11, 2023

View reviewed changes

ylwu-amzn approved these changes Jan 11, 2023

View reviewed changes

b4sjoo merged commit e37ab93 into opensearch-project:2.x Jan 11, 2023

b4sjoo added test backport 2.5 labels Jan 11, 2023

opensearch-trigger-bot bot mentioned this pull request Jan 11, 2023

[Backport 2.5] Adding backwards compatibility test for ml-commons plugin #690

Closed

b4sjoo deleted the 2.x_bwc branch January 11, 2023 00:52

b4sjoo mentioned this pull request Jan 11, 2023

[Backport 2.5]Adding backwards compatibility test for ml-commons plugin #691

Merged

5 tasks

ylwu-amzn mentioned this pull request Mar 2, 2023

[Backport to main]Adding backwards compatibility test for ml-commons plugin (#681) #776

Closed

5 tasks

b4sjoo mentioned this pull request Apr 28, 2023

Add backwards compatibility tests for automation #415

Closed

kaituo mentioned this pull request Sep 8, 2023

[2.x] Upgrade AD's bwc baseline version to 1.3.2 to resolve cluster join issue opensearch-project/anomaly-detection#1029

Merged

zelinh mentioned this pull request Jan 30, 2024

[FEATURE] Onboard distribution level BWC bundle test #1962

Open

dhrubo-os added the backport main label Dec 26, 2024

opensearch-trigger-bot bot mentioned this pull request Dec 26, 2024

[Backport main] Adding backwards compatibility test for ml-commons plugin #3298

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding backwards compatibility test for ml-commons plugin #681

Adding backwards compatibility test for ml-commons plugin #681

b4sjoo commented Jan 10, 2023

codecov-commenter commented Jan 10, 2023 •

edited by codecov bot

Loading

ylwu-amzn Jan 10, 2023

b4sjoo Jan 10, 2023

ylwu-amzn Jan 10, 2023

ylwu-amzn commented Jan 10, 2023

Adding backwards compatibility test for ml-commons plugin #681

Adding backwards compatibility test for ml-commons plugin #681

Conversation

b4sjoo commented Jan 10, 2023

Description

Check List

codecov-commenter commented Jan 10, 2023 • edited by codecov bot Loading

Codecov Report

ylwu-amzn Jan 10, 2023

Choose a reason for hiding this comment

b4sjoo Jan 10, 2023

Choose a reason for hiding this comment

ylwu-amzn Jan 10, 2023

Choose a reason for hiding this comment

ylwu-amzn commented Jan 10, 2023

codecov-commenter commented Jan 10, 2023 •

edited by codecov bot

Loading