Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed namings of test classes #83

Merged

Conversation

JohannesDaniel
Copy link
Collaborator

Fixed some test class names that did not meet the expected naming pattern (*Test instead of *Tests)

Copy link
Collaborator

@sstults sstults left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe this would've been caught if we had coverage tests in CI.

@sstults sstults merged commit 8217ea6 into opensearch-project:main Dec 5, 2024
5 checks passed
sstults pushed a commit to sstults/opensearch-learning-to-rank-base that referenced this pull request Dec 19, 2024
Signed-off-by: Johannes Peter <[email protected]>
(cherry picked from commit 8217ea6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants