Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java CI Check by using Amazon Linux 2 instead of Centos7 which is EOL #580

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Oct 23, 2024

Is your feature request related to a problem? Please provide an existing Issue # , or describe.

This PR does an upgrade of the actions/upload-artifact github action from v2 to v3 to resolve errors seen in CI checks like https://github.com/opensearch-project/performance-analyzer-rca/actions/runs/11485849764/job/31966863799?pr=577

Check List

  • Backport Labels added.
  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks
Copy link
Member Author

cwperks commented Oct 23, 2024

CI failures appear to be related to CentOS7 having archived the repositories in a vault: https://github.com/cloudspinx/centos7-vault-repositories

https://www.redhat.com/en/blog/centos-linux-going-end-life-what-does-mean-me

Signed-off-by: Craig Perkins <[email protected]>
@cwperks cwperks marked this pull request as draft October 23, 2024 21:06
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.39%. Comparing base (3c92f12) to head (daaad12).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #580      +/-   ##
============================================
- Coverage     74.42%   74.39%   -0.03%     
  Complexity     2665     2665              
============================================
  Files           317      317              
  Lines         16377    16377              
  Branches       1282     1282              
============================================
- Hits          12188    12184       -4     
- Misses         3674     3678       +4     
  Partials        515      515              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Copy link
Member Author

cwperks commented Oct 24, 2024

Got the Java CI / Building RCA package check to pass.

@cwperks cwperks changed the title Upgrade actions/upload-artifact from v2 to v3 Fix CI Checks and upgrade actions/upload-artifact from v2 to v3 Oct 24, 2024
@cwperks cwperks marked this pull request as ready for review October 24, 2024 03:04
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Copy link
Member Author

cwperks commented Oct 24, 2024

Including changes from #579

@cwperks cwperks changed the title Fix CI Checks and upgrade actions/upload-artifact from v2 to v3 Fix Java CI Check by using Amazon Linux 2 instead of Centos7 which is EOL Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant