Query grouping dashboard changes and extensive tests #33
Conversation
This reverts commit 9efdbaf. Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
deshsidd
requested review from
ansjcy,
jainankitk and
dzane17
as code owners
Signed-off-by: Siddhant Deshmukh <[email protected]>
| import QueryGroupAggregateSummary from "./Components/QueryGroupAggregateSummary"; | ||
| import QueryGroupSampleQuerySummary from "./Components/QueryGroupSampleQuerySummary"; | ||
|
|
||
| const QueryGroupDetails = ({ queries, core }: { queries: any; core: CoreStart }) => { |
There was a problem hiding this comment.
Why do we need this new component? Is it possible to reuse the QueryDetails page? Cause I see a lot of duplicate logic here with QueryDetails.tsx
There was a problem hiding this comment.
+1, Unless there is more details that we need to show on the grouping page, but even then we can extract the common parts out into a common component
| render: (query: any) => { | ||
| return ( | ||
| <span> | ||
| <EuiLink onClick={() => { |
There was a problem hiding this comment.
are we having 2 same links points to the query group details?
| const route = query.group_by === 'SIMILARITY' ? `/query-group-details/${hash(query)}` : `/query-details/${hash(query)}`; | ||
| history.push(route); | ||
| }}> | ||
| {query.query_hashcode || '-'} |
There was a problem hiding this comment.
We should probably use query_id for this if displaying single query: opensearch-project/query-insights#159
| @@ -20,6 +20,9 @@ export interface SearchQueryRecord { | |||
| indices: string[]; | |||
| phase_latency_map: PhaseLatencyMap; | |||
| task_resource_usages: Task[]; | |||
| query_hashcode: string; | |||
There was a problem hiding this comment.
+1 to @ansjcy is the new UUID field called query_hashcode or query_id?
Maybe I am not fully understanding the group-by feature, but if you do not do group_by on the table, shouldn't it show all of the single queries by themselves? Or does group-by have a different meaning in terms of the data? |
Description
Query grouping dashboard changes based on the proposed UX. Support grouping related configurations setting and viewing query groups using the query insights dashboards.
Currently, dashboards only supports Top N queries. With the introduction of grouping Top N queries by similarity, this PR aims to integrate query insights dashboard with the query grouping changes.
Change Details:
typeto filter outgroupsorqueriesIssues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Closes : #14
Screenshots
Top N queries/groups page displaying multiple query groups:
Option to filter by group/query:
Query Group Details Page after clicking on the query group row in the Top N page:
Sample Query Details section on the query group details page:
Query Configuration Page to configure Top N Query Groups:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.