-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove threat intel checkbox detector creation #1232
Remove threat intel checkbox detector creation #1232
Conversation
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving under assumption that following things are fixed:
- threat intel mention is removed from the create/update detector, edit detector pages
- pre-existing detectors which have threat intel enabled will still be able to disable detectors and detector triggers after this change?
Yes, these things have been fixed in this PR |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.16
# Create a new branch
git switch --create backport-1232-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 251e69591e87642250e77e7c903c4ef657586b4a
# Push it to GitHub
git push --set-upstream origin backport-1232-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.16 Then, create a pull request where the |
* removed threat intel from detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed trigger edit; show callout in detector details view Signed-off-by: Amardeepsingh Siglani <[email protected]> * work in progress Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated logic Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused prop Signed-off-by: Amardeepsingh Siglani <[email protected]> * simplified changes Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 251e695) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.15
# Create a new branch
git switch --create backport-1232-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 251e69591e87642250e77e7c903c4ef657586b4a
# Push it to GitHub
git push --set-upstream origin backport-1232-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.15 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.17
# Create a new branch
git switch --create backport-1232-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 251e69591e87642250e77e7c903c4ef657586b4a
# Push it to GitHub
git push --set-upstream origin backport-1232-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.17 Then, create a pull request where the |
* removed threat intel from detector creation Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed trigger edit; show callout in detector details view Signed-off-by: Amardeepsingh Siglani <[email protected]> * work in progress Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated logic Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unused prop Signed-off-by: Amardeepsingh Siglani <[email protected]> * simplified changes Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshot Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 251e695) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR moves to deprecate enabling threat intel as part of detectors. We advise user to instead use the threat intel platform.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.