Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove threat intel checkbox detector creation #1232

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented Dec 18, 2024

Description

This PR moves to deprecate enabling threat intel as part of detectors. We advise user to instead use the threat intel platform.

  • Detector creation:
image
  • Edit detector with threat intel enabled already
image
  • Details page when threat intel is enabled
image

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Copy link
Member

@eirsep eirsep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving under assumption that following things are fixed:

  1. threat intel mention is removed from the create/update detector, edit detector pages
  2. pre-existing detectors which have threat intel enabled will still be able to disable detectors and detector triggers after this change?

@amsiglan
Copy link
Collaborator Author

Approving under assumption that following things are fixed:

  1. threat intel mention is removed from the create/update detector, edit detector pages
  2. pre-existing detectors which have threat intel enabled will still be able to disable detectors and detector triggers after this change?

Yes, these things have been fixed in this PR

@amsiglan amsiglan merged commit 251e695 into opensearch-project:main Dec 18, 2024
6 of 8 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.16
# Create a new branch
git switch --create backport-1232-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 251e69591e87642250e77e7c903c4ef657586b4a
# Push it to GitHub
git push --set-upstream origin backport-1232-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport-1232-to-2.16.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 18, 2024
* removed threat intel from detector creation

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed trigger edit; show callout in detector details view

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* work in progress

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated logic

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* removed unused prop

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* simplified changes

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshot

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 251e695)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.15
# Create a new branch
git switch --create backport-1232-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 251e69591e87642250e77e7c903c4ef657586b4a
# Push it to GitHub
git push --set-upstream origin backport-1232-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport-1232-to-2.15.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.17
# Create a new branch
git switch --create backport-1232-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 251e69591e87642250e77e7c903c4ef657586b4a
# Push it to GitHub
git push --set-upstream origin backport-1232-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport-1232-to-2.17.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 18, 2024
* removed threat intel from detector creation

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed trigger edit; show callout in detector details view

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* work in progress

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated logic

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* removed unused prop

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* simplified changes

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshot

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 251e695)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants