[serverless-1.31 ]Backport: Adding support for func subscribe for creating triggers
#724
Conversation
…sed on event filters (knative#2001) * Adding support for `func subscribe` for creating mutiple triggers, based on event filters Signed-off-by: Matthias Wessendorf <[email protected]> * Update cmd/subscribe.go Co-authored-by: Luke Kingland <[email protected]> * Update cmd/subscribe.go Co-authored-by: Luke Kingland <[email protected]> * Update cmd/subscribe.go Co-authored-by: Luke Kingland <[email protected]> * Update cmd/subscribe.go Co-authored-by: Luke Kingland <[email protected]> * Update cmd/subscribe.go Co-authored-by: Luke Kingland <[email protected]> * Update cmd/subscribe.go Co-authored-by: Luke Kingland <[email protected]> * removing unused import Signed-off-by: Matthias Wessendorf <[email protected]> * running make Signed-off-by: Matthias Wessendorf <[email protected]> * Some import ogranization Signed-off-by: Matthias Wessendorf <[email protected]> * Change argument syntax Signed-off-by: Matthias Wessendorf <[email protected]> * changes Signed-off-by: Matthias Wessendorf <[email protected]> * Adding some emoji text Signed-off-by: Matthias Wessendorf <[email protected]> * 💄 move subscriptions underneath the deploy element Signed-off-by: Matthias Wessendorf <[email protected]> * adding silly emoji to build Signed-off-by: Matthias Wessendorf <[email protected]> * Adding some simple/copied/modified test Signed-off-by: Matthias Wessendorf <[email protected]> * Running 'make schema-generate' Signed-off-by: Matthias Wessendorf <[email protected]> * Update function Signed-off-by: Matthias Wessendorf <[email protected]> * Little unit test Signed-off-by: Matthias Wessendorf <[email protected]> * Adding a bit more help text Signed-off-by: Matthias Wessendorf <[email protected]> * misspell instruction Signed-off-by: Matthias Wessendorf <[email protected]> --------- Signed-off-by: Matthias Wessendorf <[email protected]> Co-authored-by: Luke Kingland <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## serverless-1.31 #724 +/- ##
==================================================
Coverage ? 63.98%
==================================================
Files ? 109
Lines ? 14671
Branches ? 0
==================================================
Hits ? 9387
Misses ? 4395
Partials ? 889
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matzew
changed the title
func subscribe for creating triggersfunc subscribe for creating triggers
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@matzew we are kind of in a code freeze with productized build done. Do we want this feature to make into 1.31 still? |
|
/close |
|
@matzew: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
backport of knative#2001 to midstream
/hold