-
Notifications
You must be signed in to change notification settings - Fork 10
[WIP] Separate crds #48
base: main
Are you sure you want to change the base?
Conversation
…a1 --kind=KnativeEventingKafkaSource
…/v1alpha1 --kind=KnativeEventingKafkaSource
…a1 --kind=KnativeEventingKafkaChannel
…/v1alpha1 --kind=KnativeEventingKafkaChannel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I like what I see, with the separated APIs/CRDs Note, when we update the CSV, for the See here for reference: openshift-knative/knative-eventing-operator#99 |
@aliok: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
JIRA: https://issues.redhat.com/browse/SRVKE-292
Done:
TODO:
https://raw.githubusercontent.com/openshift/knative-eventing-contrib/release-v${CURRENT_VERSION}/openshift/release/knative-eventing-kafka-channel-v${CURRENT_VERSION}.yaml
https://raw.githubusercontent.com/openshift/knative-eventing-contrib/release-v${CURRENT_VERSION}/openshift/release/knative-eventing-kafka-source-v${CURRENT_VERSION}.yaml
list
RBAC permissions, not sure if it is related to my changesinternal-object
s. See hide the KnativeEventings APIs knative-eventing-operator#99