Skip to content
This repository has been archived by the owner on Nov 25, 2021. It is now read-only.

[WIP] Separate crds #48

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

aliok
Copy link
Contributor

@aliok aliok commented Mar 5, 2020

JIRA: https://issues.redhat.com/browse/SRVKE-292

Done:

  • Separate CRDs
    • Channel
    • Source --> nothing in it as it simply creates the controller for the source

TODO:

  • OLM metadata
  • YAML artifacts to be separated by changing the scripts here
    • https://raw.githubusercontent.com/openshift/knative-eventing-contrib/release-v${CURRENT_VERSION}/openshift/release/knative-eventing-kafka-channel-v${CURRENT_VERSION}.yaml
    • https://raw.githubusercontent.com/openshift/knative-eventing-contrib/release-v${CURRENT_VERSION}/openshift/release/knative-eventing-kafka-source-v${CURRENT_VERSION}.yaml
  • Update operator version and upgrade to latest Knative version
  • Hide old CRD in CSV (as marking it internal, similar to this)
  • Clarify if SCC related things are necessary
  • Verification instructions
  • Kafka webhook SA is missing some list RBAC permissions, not sure if it is related to my changes
  • Any migration docs necessary?
  • Test on Minikube
  • Test on OpenShift
  • Stateful set watch?
  • Mark CRDs as internal-objects. See hide the KnativeEventings APIs knative-eventing-operator#99

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Mar 6, 2020

I like what I see, with the separated APIs/CRDs

Note, when we update the CSV, for the owned CRDs, let's also mark both as internal-objects, so that they are not visilbe in the developer console (only admins will see them).

See here for reference: openshift-knative/knative-eventing-operator#99

Base automatically changed from master to main March 8, 2021 18:55
@openshift-ci-robot
Copy link

@aliok: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants