cgu: added PreCachingConfig resource and unit tests #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaskosk
requested review from
kononovn,
trewest,
achuzhoy and
cdvultur
as code owners
sebrandon1
reviewed
May 2, 2024
pkg/cgu/precachingconfig.go
Outdated
Comment on lines
43
to
49
| if name == "" { | ||
| glog.V(100).Infof("The name of the PreCachingConfig is empty") | ||
|
|
||
| builder.errorMsg = "preCachingConfig 'name' cannot be empty" | ||
| } |
There was a problem hiding this comment.
Suggested change
| if name == "" { | |
| glog.V(100).Infof("The name of the PreCachingConfig is empty") | |
| builder.errorMsg = "preCachingConfig 'name' cannot be empty" | |
| } | |
| if name == "" { | |
| glog.V(100).Infof("The name of the PreCachingConfig is empty") | |
| builder.errorMsg = "preCachingConfig 'name' cannot be empty" | |
| return builder | |
| } |
pkg/cgu/precachingconfig.go
Outdated
Comment on lines
49
to
57
| if nsname == "" { | ||
| glog.V(100).Infof("The namespace of the PreCachingConfig is empty") | ||
|
|
||
| builder.errorMsg = "preCachingConfig 'nsname' cannot be empty" | ||
| } |
There was a problem hiding this comment.
Suggested change
| if nsname == "" { | |
| glog.V(100).Infof("The namespace of the PreCachingConfig is empty") | |
| builder.errorMsg = "preCachingConfig 'nsname' cannot be empty" | |
| } | |
| if nsname == "" { | |
| glog.V(100).Infof("The namespace of the PreCachingConfig is empty") | |
| builder.errorMsg = "preCachingConfig 'nsname' cannot be empty" | |
| return builder | |
| } |
pkg/cgu/precachingconfig.go
Outdated
| } | ||
|
|
||
| if !builder.Exists() { | ||
| return nil, fmt.Errorf("preCachingConfig object %s doesn't exist in namespace %s", name, nsname) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("preCachingConfig object %s doesn't exist in namespace %s", name, nsname) | |
| return nil, fmt.Errorf("preCachingConfig object %s does not exist in namespace %s", name, nsname) |
pkg/cgu/precachingconfig_test.go
Outdated
| testBuilder := buildValidPreCachingConfigTestBuilder(clients.GetTestClients(clients.TestClientParams{})) | ||
|
|
||
| // Create the builder rather than just adding it to the client so that the proper metadata is added and | ||
| // the update won't fail. |
There was a problem hiding this comment.
Suggested change
| // the update won't fail. | |
| // the update will not fail. |
pkg/cgu/precachingconfig_test.go
Outdated
| addToRuntimeObjects: false, | ||
| client: true, | ||
| expectedErrorText: fmt.Sprintf( | ||
| "preCachingConfig object %s doesn't exist in namespace %s", |
There was a problem hiding this comment.
Suggested change
| "preCachingConfig object %s doesn't exist in namespace %s", | |
| "preCachingConfig object %s does not exist in namespace %s", |
|
@sebrandon1 Thanks, I've updated the PR with changes |
sebrandon1
approved these changes
May 3, 2024
|
Approved! I don't have the power to resolve my comments above so that will have to be someone else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.