Support az-entra auth #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need have a separate PR to enable Flexible Server in our automation environment. |
morvencao
reviewed
Nov 28, 2024
| // The access token can be expired. but the existing connections are not invalidated. | ||
| // TODO: how to reconnect due to the network is broken etc. Right now, gorm does not have this feature. | ||
| // refer to https://github.com/go-gorm/gorm/issues/5602 & https://github.com/go-gorm/gorm/pull/1721. | ||
| token, err := cred.GetToken(context.Background(), policy.TokenRequestOptions{Scopes: []string{c.TokenRequestScope}}) |
There was a problem hiding this comment.
do we need to make the scope configurable?
There was a problem hiding this comment.
refer to the line
fs.StringVar(&c.TokenRequestScope, "db-token-request-scope", c.TokenRequestScope, "Configure the token request scope for Open-Source Relational Database Management Systems in Azure")
Signed-off-by: clyang82 <[email protected]>
|
/assign @qiujian16 |
qiujian16
approved these changes
Nov 29, 2024
machi1990
added a commit
to Azure/ARO-HCP
that referenced
this pull request
Dec 12, 2024
The following changes are included in the bump; - ensure spec is returned in the status change event when a maestro bundle is being deleted (openshift-online/maestro#225) - support entra auth for postgres (openshift-online/maestro#221) - fix maestro agent resync unstable (openshift-online/maestro#220) - register cloud events metrics(openshift-online/maestro#217) - avoid nil point in go-sdk (openshift-online/maestro#212) - update mqtt lib to resolve mqtt pinger problem (openshift-online/maestro#200) - support print date in log (openshift-online/maestro#195) - avoid race conditions on maestro-agent (openshift-online/maestro#196) - use orphan delete option as default option for read only update strategy (openshift-online/maestro#189)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: https://issues.redhat.com/browse/ACM-15835
Refer to Azure document for how to configure workload indentity: https://learn.microsoft.com/en-us/azure/aks/workload-identity-deploy-cluster
basic steps are:
azure.workload.identity/client-id: "${USER_ASSIGNED_CLIENT_ID}"Microsoft Entra Workload ID uses Service Account Token Volume Projection (that is, a service account), to enable pods to use a Kubernetes identity.azure.workload.identity/use: "true"so the pod can use workload identity.