Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: Create status with pr name #1850

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Dec 5, 2024

In gitlab the check names where showing up as a single one for every pipelines.

This would cause issue when there is multiple pipelinerun running and one of them fails. If other success it would override it and would show as success in the Pipeline.

We now create each status like in github with the applicationName / OriginalPipelineName

Example, in this pr there is two pipelinerun one good that is slower and a bad one. The bad one fail first and the slow one fail after, gitlab shows it as success:

image

since it only see as a single pipeline with different jobs:

image

with this patch we now show it as failed:

image

since they are too different pipelines:

image

Jira: https://issues.redhat.com/browse/SRVKP-6883

Changes

Submitter Checklist

  • 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

  • ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

  • ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

  • 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

  • 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

  • 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

  • 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.75%. Comparing base (425d4f2) to head (d4ad47a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
+ Coverage   65.74%   65.75%   +0.01%     
==========================================
  Files         178      178              
  Lines       13845    13840       -5     
==========================================
- Hits         9102     9101       -1     
+ Misses       4128     4124       -4     
  Partials      615      615              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

In gitlab the check names where showing up as a single one for every
pipelines.

This would cause issue when there is multiple pipelinerun running and
one of them fails. If other success it would override it and would show
as success in the Pipeline.

We now create each status like in github with the applicationName
/ OriginalPipelineName

Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel chmouel force-pushed the add-context-to-gitlab branch from e601dbf to d4ad47a Compare December 6, 2024 11:04
@chmouel chmouel merged commit 0315a46 into openshift-pipelines:main Dec 6, 2024
5 checks passed
@chmouel chmouel deleted the add-context-to-gitlab branch December 6, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants