.github: move regcred secret out of e2e

Signed-off-by: Vincent Demeester <[email protected]>
openshift-pipelines · Dec 1, 2023 · e4c60a4 · e4c60a4
1 parent 574ee9c
commit e4c60a4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -65,4 +65,11 @@ jobs:
 
       # running end-to-end test target
       - name: test-e2e
-        run: make test-e2e
+        run: |
+          set -Eeuo pipefail
+          kubectl delete secret regcred || true
+          kubectl create secret generic regcred \
+            --from-file=.dockerconfigjson=$HOME/.docker/config.json \
+          --type=kubernetes.io/dockerconfigjson
+          kubectl patch serviceaccount default -p '{"imagePullSecrets": [{"name": "regcred"}]}'
+          make test-e2e
diff --git a/test/e2e/e2e.bats b/test/e2e/e2e.bats
@@ -7,14 +7,6 @@ source ./test/helper/helper.sh
 
 	run kubectl delete taskrun --all
 	assert_success
-
-	kubectl delete secret regcred || true
-	run kubectl create secret generic regcred \
-        	--from-file=.dockerconfigjson=$HOME/.docker/config.json \
-        	--type=kubernetes.io/dockerconfigjson
-	assert_success
-	run kubectl patch serviceaccount default -p '{"imagePullSecrets": [{"name": "regcred"}]}'
-	assert_success
 
 	run tkn task start git \
 		--param="URL=https://github.com/tektoncd/community.git" \