Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing open-api gen tags to api packages #2050

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

manusa
Copy link

@manusa manusa commented Sep 30, 2024

Added the missing tag to the following packages:

  • cloudnetwork/v1
  • imageregistry/v1
  • machineconfiguration/v1
  • networkoperator/v1

These tags are necessary so that the generated openapi/generated_openapi/zz_generated.openapi.go and openapi/openapi.json are complete.

In the current state, these files are missing some definition even though they do have references to these missing definitions (e.g. EgressRouter has a reference to EgressRouterStatus which is not present).

Needed for fabric8io/kubernetes-client#6130

Added the missing tag to:
- cloudnetwork/v1
- imageregistry/v1
- machineconfiguration/v1
- networkoperator/v1

These tags are necessary so that the generated zz_generated.openapi.go
and openapi.json are complete.

In the current state, these files are missing some definition even though they
do have references to these missing definitions (e.g. EgressRouter has a reference
to EgressRouterStatus which is not present)
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 30, 2024
Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

Hello @manusa! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 30, 2024
Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

Hi @manusa. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: manusa
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants