-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added missing open-api gen tags to api packages #2050
base: master
Are you sure you want to change the base?
Conversation
Added the missing tag to: - cloudnetwork/v1 - imageregistry/v1 - machineconfiguration/v1 - networkoperator/v1 These tags are necessary so that the generated zz_generated.openapi.go and openapi.json are complete. In the current state, these files are missing some definition even though they do have references to these missing definitions (e.g. EgressRouter has a reference to EgressRouterStatus which is not present)
Hello @manusa! Some important instructions when contributing to openshift/api: |
Hi @manusa. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: manusa The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Added the missing tag to the following packages:
These tags are necessary so that the generated
openapi/generated_openapi/zz_generated.openapi.go
andopenapi/openapi.json
are complete.In the current state, these files are missing some definition even though they do have references to these missing definitions (e.g.
EgressRouter
has a reference toEgressRouterStatus
which is not present).Needed for fabric8io/kubernetes-client#6130