Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-4071: GA MetricsCollectionProfiles #2084

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Nov 5, 2024

Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

Hello @rexagod! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 5, 2024
Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rexagod
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rexagod added a commit to rexagod/origin that referenced this pull request Nov 5, 2024
rexagod added a commit to rexagod/origin that referenced this pull request Nov 5, 2024
@rexagod rexagod changed the title GA MetricsCollectionProfiles MON-4071: GA MetricsCollectionProfiles Nov 5, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2024

@rexagod: This pull request references MON-4071 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Tests: openshift/origin#28889

Other relevant PRs:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rexagod
Copy link
Member Author

rexagod commented Nov 5, 2024

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2024

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2024

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to this:

Tests: openshift/origin#28889

Other relevant PRs:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rexagod
Copy link
Member Author

rexagod commented Nov 6, 2024

/test e2e-aws-serial-techpreview
/test verify

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2024

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to this:

Tests: openshift/origin#28889

Other relevant PRs:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2024

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to this:

Tests: openshift/origin#28889

Other relevant PRs:



_The failures observed for test suite on all metal platforms stem from the absence of cluster-monitoring-config (CMO's configuration manifest). I'll send a patch to create one if it doesn't exist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2024

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to this:

Tests: openshift/origin#28889

Other relevant PRs:



The failures observed for test suite on all metal platforms stem from the absence of cluster-monitoring-config (CMO's configuration manifest). I'll send a patch to create one if it doesn't exist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2024

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to this:

Tests: openshift/origin#28889

Other relevant PRs:



The failures observed for test suite on all metal platforms stem from the absence of cluster-monitoring-config (CMO's configuration manifest). I'll send a patch to create one if it doesn't exist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2024

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to this:

Tests: openshift/origin#28889

Other relevant PRs:



The failures observed for test suite on all metal platforms stem from the absence of cluster-monitoring-config (CMO's configuration manifest). I'll send a patch to create one when it doesn't exists.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2024

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to this:

Tests: openshift/origin#28889

Other relevant PRs:



The failures observed for test suite on all metal platforms stem from the absence of cluster-monitoring-config (CMO's configuration manifest). I'll send a patch to create one when it doesn't exists.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rexagod added a commit to rexagod/origin that referenced this pull request Nov 12, 2024
rexagod added a commit to rexagod/origin that referenced this pull request Nov 14, 2024
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

@rexagod: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify c1b653a link true /test verify
ci/prow/e2e-aws-serial-techpreview c1b653a link true /test e2e-aws-serial-techpreview
ci/prow/lint c1b653a link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants