-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-44319: Fix oauth-proxy e2e-component tests #289
OCPBUGS-44319: Fix oauth-proxy e2e-component tests #289
Conversation
ShazaAldawamneh
commented
Nov 11, 2024
•
edited
Loading
edited
- We’re unable to find a stable and accessible OAuth-proxy image, which is causing a bug that we haven’t fully resolved yet. @ibihim made a PR to address this , but it’s not a complete solution since the image path doesn’t seem consistently available.
- @ibihim tried referencing the OAuth-proxy image from the OpenShift openshift namespace, but it didn’t work reliably.
- There’s an imagestream for OAuth-proxy in the openshift namespace, which we might be able to reference in tests, but you're not certain of the correct Docker URL format for it. Also, it’s possible that there are permission issues, which could be why the image isn’t accessible when referenced this way.
@ShazaAldawamneh: This pull request references Jira Issue OCPBUGS-44319, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
@ShazaAldawamneh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
/approve |
@sjenning: This pull request references Jira Issue OCPBUGS-44319, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label approved |
@sjenning: Can not set label approved: Must be member in one of these teams: [openshift-release-oversight openshift-staff-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
/label approved |
@sjenning: Can not set label approved: Must be member in one of these teams: [openshift-release-oversight openshift-staff-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: ibihim, ShazaAldawamneh, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ShazaAldawamneh: Jira Issue OCPBUGS-44319: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-44319 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: golang-github-openshift-oauth-proxy |
/cherry-pick release-4.18 |
@ShazaAldawamneh: new pull request created: #299 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |