Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect rd query param for redirects #296

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gbenhaim
Copy link
Member

@gbenhaim gbenhaim commented Dec 5, 2024

Respect rd query param for redirects when not using manual sign in or when the proxy endpoint returns the sign in page.

Respect rd query param for redirects when not using manual sign in
or when the proxy endpoint returns the sign in page.

Signed-off-by: Gal Ben Haim <[email protected]>
@openshift-ci openshift-ci bot requested a review from deads2k December 5, 2024 11:19
Copy link

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gbenhaim
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Gal Ben Haim <[email protected]>
@gbenhaim
Copy link
Member Author

gbenhaim commented Dec 5, 2024

/test e2e-component

@gbenhaim
Copy link
Member Author

gbenhaim commented Dec 8, 2024

/test

Copy link

openshift-ci bot commented Dec 8, 2024

@gbenhaim: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test e2e-aws
/test e2e-component
/test images
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-oauth-proxy-master-e2e-aws
pull-ci-openshift-oauth-proxy-master-e2e-component
pull-ci-openshift-oauth-proxy-master-images
pull-ci-openshift-oauth-proxy-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-oauth-proxy-master-unit
pull-ci-openshift-oauth-proxy-master-verify
pull-ci-openshift-oauth-proxy-master-verify-deps

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gbenhaim
Copy link
Member Author

gbenhaim commented Dec 8, 2024

/test unit
/test e2e-component

Copy link

openshift-ci bot commented Dec 8, 2024

@gbenhaim: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn e077d16 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-component e077d16 link true /test e2e-component

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant