-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable telemetry in OSASINFRA DT #418
Enable telemetry in OSASINFRA DT #418
Conversation
Hi @mandre. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Compared to uni01alpha that is the other DT to enable telemetry, we're not enabling autoscaling as it requires the additional heat service. Depends on openstack-k8s-operators/ci-framework#2449.
c4a9039
to
47f211d
Compare
/ok-to-test |
@mandre Has anyone tested this in a testproject job? |
This looks fine to me. Just waiting for an answer to Andrew's question. |
I tested it locally at the time I wrote it, but let me ping our QE to check if they've run it as part of a job and come back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fultonj, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build succeeded (gate pipeline). ✔️ noop SUCCESS in 0s |
f09f1b4
into
openstack-k8s-operators:main
/cherrypick 18.0-fr1 |
@eurijon: new pull request created: #449 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Compared to uni01alpha that is the other DT to enable telemetry, we're not enabling autoscaling as it requires the additional heat service.
Depends on openstack-k8s-operators/ci-framework#2449.