Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable telemetry in OSASINFRA DT #418

Conversation

mandre
Copy link
Contributor

@mandre mandre commented Oct 14, 2024

Compared to uni01alpha that is the other DT to enable telemetry, we're not enabling autoscaling as it requires the additional heat service.

Depends on openstack-k8s-operators/ci-framework#2449.

@openshift-ci openshift-ci bot requested review from cjeanner and leifmadsen October 14, 2024 05:46
Copy link

openshift-ci bot commented Oct 14, 2024

Hi @mandre. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Compared to uni01alpha that is the other DT to enable telemetry, we're
not enabling autoscaling as it requires the additional heat service.

Depends on openstack-k8s-operators/ci-framework#2449.
@mandre mandre force-pushed the telemetry-dt-osasinfra branch from c4a9039 to 47f211d Compare November 4, 2024 13:05
@abays
Copy link
Contributor

abays commented Nov 4, 2024

/ok-to-test

@abays
Copy link
Contributor

abays commented Nov 4, 2024

@mandre Has anyone tested this in a testproject job?

@fultonj fultonj added the needs-info Information is requested of the reporter or reviewers label Nov 4, 2024
@fultonj
Copy link
Contributor

fultonj commented Nov 4, 2024

This looks fine to me. Just waiting for an answer to Andrew's question.

@mandre
Copy link
Contributor Author

mandre commented Nov 4, 2024

@mandre Has anyone tested this in a testproject job?

I tested it locally at the time I wrote it, but let me ping our QE to check if they've run it as part of a job and come back to you.

@eurijon
Copy link
Contributor

eurijon commented Nov 15, 2024

@abays @fultonj hey, after solving some node-exporter image's registry related param issues at the job definition level, the osasinfra DT has been successfully deployed with telemetry in a testproject.

Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fultonj, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5041c2484b914f2bb7a7f7bf4ae0851f

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 45s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f09f1b4 into openstack-k8s-operators:main Nov 15, 2024
7 checks passed
@eurijon
Copy link
Contributor

eurijon commented Nov 18, 2024

/cherrypick 18.0-fr1

@openshift-cherrypick-robot

@eurijon: new pull request created: #449

In response to this:

/cherrypick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-info Information is requested of the reporter or reviewers ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants