-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Manila support in DCN jobs #2573
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR! ❤️ |
@@ -94,7 +94,7 @@ data: | |||
{% endif %} | |||
{% endfor %} | |||
manila: | |||
enabled: false | |||
enabled: true | |||
manilaAPI: | |||
customServiceConfig: | | |||
[DEFAULT] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In DCN, according to https://github.com/openstack-k8s-operators/architecture/tree/main/examples/dt/dcn, there are three Ceph clusters..
You'd need the appropriate Ceph configuration plugged to a specific instance of "manila-share"; and a corresponding extra-mount with the ceph secret.
See how cinder volume is configured beginning line 27 in this file..
We need a change to the "architecture" repo that enables setting "ManilaShares" similar to CinderVolumes so we can do that..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, and also, we might need to change manilaShares
here to iterate over the AZs:
manilaShares:
{% for _ceph in _ceph_vars_list %}
{{ _ceph.cifmw_ceph_client_cluster }}:
customServiceConfig: |
[DEFAULT]
enabled_share_backends = cephfs
enabled_share_protocols = cephfs
[cephfs]
driver_handles_share_servers = False
share_backend_name = cephfs
share_driver = manila.share.drivers.cephfs.driver.CephFSDriver
cephfs_conf_path = /etc/ceph/{{ _ceph.cifmw_ceph_client_cluster }}.conf
cephfs_cluster_name = {{ _ceph.cifmw_ceph_client_cluster }}
cephfs_auth_id=openstack
cephfs_volume_mode = 0755
cephfs_protocol_helper_type = CEPHFS
{% endfor %}
@@ -94,7 +94,7 @@ data: | |||
{% endif %} | |||
{% endfor %} | |||
manila: | |||
enabled: false | |||
enabled: true | |||
manilaAPI: | |||
customServiceConfig: | | |||
[DEFAULT] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, and also, we might need to change manilaShares
here to iterate over the AZs:
manilaShares:
{% for _ceph in _ceph_vars_list %}
{{ _ceph.cifmw_ceph_client_cluster }}:
customServiceConfig: |
[DEFAULT]
enabled_share_backends = cephfs
enabled_share_protocols = cephfs
[cephfs]
driver_handles_share_servers = False
share_backend_name = cephfs
share_driver = manila.share.drivers.cephfs.driver.CephFSDriver
cephfs_conf_path = /etc/ceph/{{ _ceph.cifmw_ceph_client_cluster }}.conf
cephfs_cluster_name = {{ _ceph.cifmw_ceph_client_cluster }}
cephfs_auth_id=openstack
cephfs_volume_mode = 0755
cephfs_protocol_helper_type = CEPHFS
{% endfor %}
As discussed, we also need to patch https://github.com/openstack-k8s-operators/architecture/blob/main/examples/dt/dcn/service-values.yaml#L198 and provide 3 shares (see glance and cinder as an example) |
c8c8d71
to
0c03336
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0c03336
to
82c3fae
Compare
82c3fae
to
8846a7a
Compare
Patch to openstack-k8s-operators/architecture#467 looks good to me |
In general I'm +1 to merge but let's confirm by a downstream job. After Liron confirms I say we merge. |
No description provided.