Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Manila support in DCN jobs #2573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lkuchlan
Copy link
Contributor

No description provided.

@github-actions github-actions bot marked this pull request as draft November 27, 2024 10:46
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@lkuchlan lkuchlan marked this pull request as ready for review December 9, 2024 08:24
@lkuchlan lkuchlan changed the title Enable Manila support in DCN jobs [DNM] Enable Manila support in DCN jobs Dec 9, 2024
@@ -94,7 +94,7 @@ data:
{% endif %}
{% endfor %}
manila:
enabled: false
enabled: true
manilaAPI:
customServiceConfig: |
[DEFAULT]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In DCN, according to https://github.com/openstack-k8s-operators/architecture/tree/main/examples/dt/dcn, there are three Ceph clusters..

You'd need the appropriate Ceph configuration plugged to a specific instance of "manila-share"; and a corresponding extra-mount with the ceph secret.

See how cinder volume is configured beginning line 27 in this file..

We need a change to the "architecture" repo that enables setting "ManilaShares" similar to CinderVolumes so we can do that..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, and also, we might need to change manilaShares here to iterate over the AZs:

manilaShares:
{% for _ceph in _ceph_vars_list %}
    {{ _ceph.cifmw_ceph_client_cluster }}:
      customServiceConfig: |
          [DEFAULT]
          enabled_share_backends = cephfs
          enabled_share_protocols = cephfs
          [cephfs]
          driver_handles_share_servers = False
          share_backend_name = cephfs
          share_driver = manila.share.drivers.cephfs.driver.CephFSDriver
          cephfs_conf_path = /etc/ceph/{{ _ceph.cifmw_ceph_client_cluster }}.conf
          cephfs_cluster_name = {{ _ceph.cifmw_ceph_client_cluster }}
          cephfs_auth_id=openstack
          cephfs_volume_mode = 0755
          cephfs_protocol_helper_type = CEPHFS
{% endfor %}

@@ -94,7 +94,7 @@ data:
{% endif %}
{% endfor %}
manila:
enabled: false
enabled: true
manilaAPI:
customServiceConfig: |
[DEFAULT]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, and also, we might need to change manilaShares here to iterate over the AZs:

manilaShares:
{% for _ceph in _ceph_vars_list %}
    {{ _ceph.cifmw_ceph_client_cluster }}:
      customServiceConfig: |
          [DEFAULT]
          enabled_share_backends = cephfs
          enabled_share_protocols = cephfs
          [cephfs]
          driver_handles_share_servers = False
          share_backend_name = cephfs
          share_driver = manila.share.drivers.cephfs.driver.CephFSDriver
          cephfs_conf_path = /etc/ceph/{{ _ceph.cifmw_ceph_client_cluster }}.conf
          cephfs_cluster_name = {{ _ceph.cifmw_ceph_client_cluster }}
          cephfs_auth_id=openstack
          cephfs_volume_mode = 0755
          cephfs_protocol_helper_type = CEPHFS
{% endfor %}

@fmount fmount requested a review from fultonj December 18, 2024 09:36
@fmount
Copy link
Contributor

fmount commented Dec 18, 2024

As discussed, we also need to patch https://github.com/openstack-k8s-operators/architecture/blob/main/examples/dt/dcn/service-values.yaml#L198 and provide 3 shares (see glance and cinder as an example)

@lkuchlan lkuchlan requested a review from a team as a code owner December 18, 2024 10:39
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign viroel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lkuchlan lkuchlan changed the title [DNM] Enable Manila support in DCN jobs Enable Manila support in DCN jobs Dec 18, 2024
@fultonj
Copy link
Contributor

fultonj commented Dec 19, 2024

Patch to openstack-k8s-operators/architecture#467 looks good to me

@fultonj
Copy link
Contributor

fultonj commented Dec 19, 2024

In general I'm +1 to merge but let's confirm by a downstream job. After Liron confirms I say we merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants