-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not enforce Cycle & Foot Path or Cycle & Foot Crossing in Norway #1193
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
I'm sorry, I'm not sufficiently involved in the iD community to understand what you wrote. However, the change I'm proposing doesn't appear to add any complexity. I'm just adding another country to an existing list of countries. Could you explain the added complexity? |
It's a relatively straight-forward change, so I imagine the review will be quick and simple. I don't know the process to move this forward. Is there something that needs to be done? |
Any progress on approving this? It's quite simple, and it seems it's already been reviewed. |
For me, this is the kind of PR I would like @tyrasd to review and merge. I was also hoping for #1201 to be merged first and then apply this change on top of it. But the other way around is possible to, of course. |
I don't mind who reviews it. Having tagged someone who can or should will hopefully speed this up. Thank you. |
@tyrasd since this is kind of blocking #1384 could you have a look at this. I don't have the time ATM to look into it in detail. A view notes that I did not investigate futher
The bigger question here might be, if we should continue to add the |
Once the PR preview is there, please use the testing template to document testcases https://github.com/openstreetmap/id-tagging-schema/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L24-L70 |
The goal is not to remove For combined footways and cycleways, i.e. Some countries have decided not to add I don't see that NO is any different from the other countries. Does DE's presence on the exclusion list make the situation worse for DE? |
…NO) due to the NO community not applying bicycle=designated on highway=cycleway Also fix an apparent bug in that DE is excluded from Cycle & Foot Path, but not from Cycle & Foot Crossing.
605e71d
to
122077f
Compare
🍱 You can preview the tagging presets of this pull request here. |
@balchen I still might be misunderstanding this, sorry if this is the case. But the wiki and your commend make me think that this PR is not what we want to do… I rebased this PR in order to get the preview going, so we can look at the results of this PR.
My understanding is, that you only want the Those regional presets are used in countries, where the recommendation is to use I think removing the shared preset altogether makes for a worse user experience and will lead to less consistent tagging of infrastructure. Now that the preview is there, please follow the recommendations in #1193 (comment) to create test cases for this PR. |
Test-DocumentationPreview links & Sidebar ScreenshotsSearchAvailable cycle presets for way in NO: Info-
|
The goal of the NO community is to avoid that iD users apply a preset that creates tagging which is not according to schema for NO.
Which regional presets are you referring to? |
Ref #1205, it occurs to me that the ideal solution is for a preset to read/apply different tags in different regions. That would allow for a unified user experience while maintaining regional differences. The concept would probably be applicable to many other cases. |
@balchen but now there is no preset for this case from your wiki at all https://wiki.openstreetmap.org/wiki/No:Map_Features#Sykkel I don't think that is something that we should be doing. Removing a whole preset just to prevent a superfluous tag – which, btw is currently used a lot in Norway (maybe due to iD, but still). The one superfluous tag does less harm to the data than having no preset for this case so iD users have to come up with their own interpretation of how to tag this.
Shared bicycle and footway have different recommended tagging in different countries. In some its |
I created #1411 to discuss the solution that would IMO resolve this issue in a better way. |
You're right in that there is no preset that matches the desired tagging. If this is desirable, we'd need to create a new preset for this case, then. Do you know how this solved for DE? Or is this an issue there as well? |
DE is one of the countries that recommend the hw=path tagging pattern, so this hw=cycleway preset is hidden and the other one is there. (But the other one is incomplete, which is a different story/PR.) I will close this now, since it does not have the desired effect. Lets look see what feedback is given to #1411 . |
Do not enforce Cycle & Foot Path or Cycle & Foot Crossing in Norway (NO) due to the NO community not applying bicycle=designated on highway=cycleway. See https://wiki.openstreetmap.org/wiki/No:Map_Features#Sykkel for reference.
Also fix an apparent bug in that DE is excluded from Cycle & Foot Path, but not from Cycle & Foot Crossing.