Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not enforce Cycle & Foot Path or Cycle & Foot Crossing in Norway #1193

Closed
wants to merge 1 commit into from

Conversation

balchen
Copy link

@balchen balchen commented Apr 6, 2024

Do not enforce Cycle & Foot Path or Cycle & Foot Crossing in Norway (NO) due to the NO community not applying bicycle=designated on highway=cycleway. See https://wiki.openstreetmap.org/wiki/No:Map_Features#Sykkel for reference.

Also fix an apparent bug in that DE is excluded from Cycle & Foot Path, but not from Cycle & Foot Crossing.

@tordans

This comment was marked as outdated.

@balchen
Copy link
Author

balchen commented Apr 7, 2024

FYI we discussed an update path to the current crossing presets during the last iD community meetup. This hat not been properly documented nor implemented, though. I think we should first work on this cleanup before adding more complexity on top of it.

I'm sorry, I'm not sufficiently involved in the iD community to understand what you wrote.

However, the change I'm proposing doesn't appear to add any complexity. I'm just adding another country to an existing list of countries. Could you explain the added complexity?

@balchen
Copy link
Author

balchen commented Apr 13, 2024

It's a relatively straight-forward change, so I imagine the review will be quick and simple. I don't know the process to move this forward. Is there something that needs to be done?

@balchen
Copy link
Author

balchen commented Jun 21, 2024

Any progress on approving this? It's quite simple, and it seems it's already been reviewed.

@tordans tordans requested a review from tyrasd June 23, 2024 04:44
@tordans
Copy link
Collaborator

tordans commented Jun 23, 2024

For me, this is the kind of PR I would like @tyrasd to review and merge. I was also hoping for #1201 to be merged first and then apply this change on top of it. But the other way around is possible to, of course.

@balchen
Copy link
Author

balchen commented Jun 23, 2024

I don't mind who reviews it. Having tagged someone who can or should will hopefully speed this up. Thank you.

@tordans
Copy link
Collaborator

tordans commented Dec 19, 2024

@tyrasd since this is kind of blocking #1384 could you have a look at this. I don't have the time ATM to look into it in detail. A view notes that I did not investigate futher

  • I did not find a PR preview (comment); did not understand why there is none / how to trigger it; so no preview is possible ==> I rebased and force pushed the changes in this branch and now a preview is generated
  • I am really sure this PR does what balchen described in the description. If the goal is to remove the bicycle=designated, which disable the whole preset? Doesn't that make the situation worse because now no presets are present at all? Or… which preset is triggered instead? – I guess we need example ways for that.

The bigger question here might be, if we should continue to add the bicycle=designated on highway=cycleway. AFAIK there is consensus that it is the implied default. We make it more explicit in those cases where foot+bike is involved by I don't think routers or data consumers actually need it. So maybe we should remove that alltogether… would that resolve the situation?

@tordans
Copy link
Collaborator

tordans commented Dec 19, 2024

Once the PR preview is there, please use the testing template to document testcases https://github.com/openstreetmap/id-tagging-schema/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L24-L70

@balchen
Copy link
Author

balchen commented Dec 19, 2024

The goal is not to remove bicycle=designated, but to not enforce it for combined footways and cycleways for NO.

For combined footways and cycleways, i.e. highway=cycleway with foot=designated, there is not currently a consensus that bicycle=designated is superfluous.

Some countries have decided not to add bicycle=designated to combined footways and cycleways, and I assume these countries are in the exclusion list, except NO.

I don't see that NO is any different from the other countries. Does DE's presence on the exclusion list make the situation worse for DE?

…NO) due to the NO community not applying bicycle=designated on highway=cycleway

Also fix an apparent bug in that DE is excluded from Cycle & Foot Path, but not from Cycle & Foot Crossing.
@tordans tordans force-pushed the bicycle_foot_not_no branch from 605e71d to 122077f Compare December 19, 2024 12:16
Copy link

🍱 You can preview the tagging presets of this pull request here.

@tordans
Copy link
Collaborator

tordans commented Dec 19, 2024

@balchen I still might be misunderstanding this, sorry if this is the case. But the wiki and your commend make me think that this PR is not what we want to do…

I rebased this PR in order to get the preview going, so we can look at the results of this PR.
Eg https://pr-1193--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=w963473070&locale=en&map=16.96/59.05554/6.65107

My understanding is, that you only want the bicycle=designated to not be used. But this change makes the whole preset disappear and as such all shared foot+bike ways being presented as bike ways.

Those regional presets are used in countries, where the recommendation is to use highway=path instead of cycleway for shared ways. (And even then having the regional presets is not ideal because the tagging is still valid, just not recommended … and will now show in iD ATM, which I is what I thinking about in #1205)

I think removing the shared preset altogether makes for a worse user experience and will lead to less consistent tagging of infrastructure.


Now that the preview is there, please follow the recommendations in #1193 (comment) to create test cases for this PR.

@balchen
Copy link
Author

balchen commented Dec 19, 2024

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1193--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=w41372170&locale=en&map=18.85/58.93795/5.75685

Search

Available cycle presets for way in NO:

image

Info-i

Not relevant.

Wording

Not relevant.

@balchen
Copy link
Author

balchen commented Dec 19, 2024

My understanding is, that you only want the bicycle=designated to not be used. But this change makes the whole preset disappear and as such all shared foot+bike ways being presented as bike ways.

The goal of the NO community is to avoid that iD users apply a preset that creates tagging which is not according to schema for NO.

Those regional presets are used in countries, where the recommendation is to use highway=path instead of cycleway for shared ways.

Which regional presets are you referring to?

@balchen
Copy link
Author

balchen commented Dec 19, 2024

Ref #1205, it occurs to me that the ideal solution is for a preset to read/apply different tags in different regions. That would allow for a unified user experience while maintaining regional differences. The concept would probably be applicable to many other cases.

@tordans
Copy link
Collaborator

tordans commented Dec 19, 2024

@balchen but now there is no preset for this case from your wiki at all

https://wiki.openstreetmap.org/wiki/No:Map_Features#Sykkel

image

I don't think that is something that we should be doing. Removing a whole preset just to prevent a superfluous tag – which, btw is currently used a lot in Norway (maybe due to iD, but still). The one superfluous tag does less harm to the data than having no preset for this case so iD users have to come up with their own interpretation of how to tag this.

Those regional presets are used in countries, where the recommendation is to use highway=path instead of cycleway for shared ways.

Which regional presets are you referring to?

Shared bicycle and footway have different recommended tagging in different countries. In some its highway=path + foot=designated + bicycle=designated (Preset missing). In some it highway=cycleway + foot=designated + (bicylce=designated) (Preset).

@tordans
Copy link
Collaborator

tordans commented Dec 19, 2024

I created #1411 to discuss the solution that would IMO resolve this issue in a better way.

@balchen
Copy link
Author

balchen commented Dec 19, 2024

You're right in that there is no preset that matches the desired tagging. If this is desirable, we'd need to create a new preset for this case, then. Do you know how this solved for DE? Or is this an issue there as well?

@tordans
Copy link
Collaborator

tordans commented Dec 19, 2024

Do you know how this solved for DE? Or is this an issue there as well?

DE is one of the countries that recommend the hw=path tagging pattern, so this hw=cycleway preset is hidden and the other one is there. (But the other one is incomplete, which is a different story/PR.)


I will close this now, since it does not have the desired effect. Lets look see what feedback is given to #1411 .

@tordans tordans closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants