Add date and url settings for offline message #5403
+51
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
offline-message
branch
4 times, most recently
from
d231d5d to
337af7b
Compare
tomhughes
reviewed
Dec 17, 2024
There was a problem hiding this comment.
I had been thinking we should make the message configurable because in this case it wasn't really database maintenance but that is problematic from a translation point of view.
Maybe we should just remove the references to database maintenance in favour of this solution with a URL to an explanatory notice?
Perhaps this is generic enough: |
AntonKhorev
force-pushed
the
offline-message
branch
from
337af7b to
6569215
Compare
|
Removed "database" from "maintenance": |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current message doesn't say much about how long the api/db is expected to stay down.
on map layout:
on site layout:
