-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: prettify output log #4263
Conversation
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options. 变更概述演练此次拉取请求主要修改了输出通道(Output Channel)的实现和接口。在多个文件中添加了 变更
序列图sequenceDiagram
participant ExtHost as 扩展主机
participant MainThread as 主线程
participant OutputChannel as 输出通道
ExtHost->>MainThread: 调用 $appendLine
MainThread->>OutputChannel: 追加文本行
OutputChannel-->>MainThread: 确认完成
MainThread-->>ExtHost: 返回成功
可能相关的 PR
建议标签
建议评审人
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🔇 Additional comments (8)packages/extension/src/browser/vscode/api/main.thread.output.ts (1)
packages/extension/src/hosted/api/vscode/ext.host.output.ts (3)
packages/output/src/browser/output.channel.ts (3)
packages/extension/src/common/vscode/window.ts (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4263 +/- ##
==========================================
- Coverage 53.72% 53.71% -0.02%
==========================================
Files 1622 1622
Lines 98572 98580 +8
Branches 20143 20145 +2
==========================================
- Hits 52955 52949 -6
- Misses 37911 37920 +9
- Partials 7706 7711 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types
Background or solution
before:
after:
Changelog
改进 log output 的输出
Summary by CodeRabbit
$appendLine
方法,允许向输出通道追加行。OutputChannelImpl
类中的appendLine
方法,以直接调用新的$appendLine
方法。LogOutputChannelImpl
类中的日期格式化逻辑,提升可读性和可维护性。padLeft
函数,优化代码结构。OutputChannel
类中的文本插入方法,改为使用applyEdits
直接修改文本模型。