Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: add custom sorting to the chemical probes table #279

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

LucaFumis
Copy link
Contributor

@LucaFumis LucaFumis commented Oct 24, 2023

[Platform]: add custom sorting to the chemical probes table

Description

The Chemical Probes widget table, on the target profile page, used to have a "custom" sorting. This PR adds back more accurate sorting based on score, quality and origin. @ireneisdoomed can confirm if this approach is suitable and the results are OK.

Note: this is an old ticket, so not high priority. Need to confirm expected functionality before code review.

Issue: # opentargets/issues#2742
Deploy preview: https://deploy-preview-279--ot-platform.netlify.app/

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

See Chemical Probes widget at below link; probes with the same score should be prioritised by quality and origin:

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@LucaFumis
Copy link
Contributor Author

Hi @ireneisdoomed if you feel this approach to sorting works from a user perspective, then we can ask @carcruz to review and merge. Otherwise we can just discard it and keep the widget table as it is - no problem at all.

@carcruz carcruz merged commit c0e2ea6 into main Nov 9, 2023
6 of 9 checks passed
@carcruz carcruz deleted the lf-probes-sorting branch November 9, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants