Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: update clinicaltrials URL in config #281

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

LucaFumis
Copy link
Contributor

@LucaFumis LucaFumis commented Oct 25, 2023

[Platform]: update clinicaltrials URL in config

Description

Update the clinicaltrials base URL in the platform config (urls.js file); this seems to only be used in the Indications widget on drug profile page.
Hence it appears that only packages/sections/src/utils/urls.js is being used: might need to review the use of the other two files.

Note: ClinicalTrials now uses a correct redirect from the old URLs so this fix might no longer be strictly required.
Also, if the URL will come from the API, this fix will also need to be updated accordingly.

Issue: opentargets/issues#3048
Deploy preview: (link)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Check the inications widget on any drug profile page and see the link in the last column:

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@carcruz carcruz merged commit 6f91ada into main Nov 9, 2023
9 checks passed
@carcruz carcruz deleted the lf-clinicaltrials-3048 branch November 9, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants