Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: Fix lead variant link from PheWas plot tooltip #620

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

gjmcn
Copy link
Contributor

@gjmcn gjmcn commented Dec 10, 2024

Description

When lead variant is same as page variant, show variant id as plain text (not a link) with 'self' chip - as do in table.

Add unique key to PheWas plot to prevent widget crashing when follow lead variant link to another variant page.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checked on variant page.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have made corresponding changes to the documentation

@carcruz carcruz merged commit 9af583e into main Dec 11, 2024
11 checks passed
@carcruz carcruz deleted the gm-phewas-self branch December 11, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants