Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] allow using shared boost libraries #2653

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

milas
Copy link

@milas milas commented Dec 27, 2024

Do not unconditionally set Boost_USE_STATIC_LIBS but instead default it to true.

This allows building with shared Boost libraries, which can be useful for OS distribution packaging, for example.

The default is the same if not defined, so this is a backwards compatible change: unless explicitly set to false, static Boost libs will still be used.

In particular, this is useful for NixOS, where the static Boost lib will not work.

See also:

Do not unconditionally set `Boost_USE_STATIC_LIBS` but instead default
it to `true`.

This allows building with shared Boost libraries, which can be useful
for OS distribution packaging, for example.

The default is the same if not defined, so this is a backwards
compatible change: unless explicitly set to `false`, static Boost
libs will still be used.
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.64%. Comparing base (2b41187) to head (6fcae37).
Report is 910 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2653       +/-   ##
===========================================
- Coverage   55.77%   43.64%   -12.13%     
===========================================
  Files          87      106       +19     
  Lines        6890    13254     +6364     
  Branches        0      953      +953     
===========================================
+ Hits         3843     5785     +1942     
- Misses       3047     7163     +4116     
- Partials        0      306      +306     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants