Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ImageSharp code example to current API #44

Closed
wants to merge 1 commit into from
Closed

update ImageSharp code example to current API #44

wants to merge 1 commit into from

Conversation

Sioma112233
Copy link

The API of ImageSharp changed a bit and the code example that uses ImageSharp is now outdated.
This fixes this document.

Related also to this issue in a different repo

The API of ImageSharp changed a bit and the code example that uses ImageSharp is now outdated.
This fixes this document
Copy link
Member

@frederikja163 frederikja163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the appropriate change to this also made to the source of the tutorails?

@frederikja163
Copy link
Member

Also had merge conflicts, can you double check those @Sioma112233

@Sioma112233
Copy link
Author

Was the appropriate change to this also made to the source of the tutorails?

Not sure I understand, Isn't this repo the source of the tutorials? (the tutorials in the site opentk.net)

About the merge conflicts, the name of the file was changed so that's the issue.
I'm gonna open a new PR because I already deleted my forked repo so the original branch doesn't exist

@frederikja163
Copy link
Member

If you can resolve the merge conflicts i will be happy to merge this. A new website build is up ahead.

@NogginBops
Copy link
Member

@frederikja163 you might have missed that you already merged this in #47 .
This is an old PR that isn't relevant anymore. Closing.

@NogginBops NogginBops closed this May 22, 2021
@NogginBops
Copy link
Member

Ah wait, I spoke too soon. I didn't see that this change was to a different file from #47 .
It seems like I'm not able to re-open this PR, though I think it might be easier to change in a new PR.

Keeping the code of the website and the tutorial repo in sync does seem to be a slight issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants