v2.26.1 #702
v2.26.1 #702
Conversation
…ments) (#688) * Bump OpenTok Android and iOS SDK to 2.26.0 * Update modules with npm audit fix * Update react and react native modules * Adding OTPublisher.setVideoTransformers() method * .gitignore android/.gradle files * Typo correction * Correctly Android VideoTransformer() usage * Add live captions API enhancements * Rev Vonage Video Android and iOS SDKs to 2.26.1 * Marking some issues resolved in the change log And other docs edits * Fix subscribeToCaptions typos * Readme correction * Fix registration of subscribeToCaptions event * Fix typos in captionReceived event implementation * Fix OTSubscriber properties -- issue #694 (These were essentially being ignored.) * Docs edit * Set Subscriber captions delegate and listener * docs correction * rev version to 2.26.1
| @@ -100,6 +101,25 @@ public static List<IceServer> sanitizeIceServer(ReadableArray serverList) { | |||
| return iceServers; | |||
| } | |||
|
|
|||
| public static ArrayList<VideoTransformer> sanitizeVideoTransformerList(PublisherKit publisher, ReadableArray transformerList) { | |||
| ArrayList<VideoTransformer> nativeVideoTransformers = new ArrayList<>(); | |||
| if (transformerList != null) { | |||
There was a problem hiding this comment.
Nit: if you check for this first, you can bail early (e.g., not have to instantiated nativeVideoTransformers).
| for (int i = 0; i < transformerList.size(); i++) { | ||
| String transformerName = transformerList.getMap(i).getString("name"); | ||
| if (transformerName == "BackgroundReplacement" ) { | ||
| // Only implemented in iOS -- ignore in Androd for now. |
There was a problem hiding this comment.
Nit: misspelled Android.
| VideoTransformer transformer = publisher.new VideoTransformer( | ||
| transformerName, | ||
| transformerList.getMap(i).getString("properties") | ||
| ); |
There was a problem hiding this comment.
Nit: might be simpler to use a map since you're taking an "input list" and removing filters that aren't part of your "allowed list".
There was a problem hiding this comment.
@v-kpheng an you please clarify? The transformerList parameter is a ReadableArray (not a map), since the corresponding JavaScript object is an array. And it is an array of objects (in JavaScript), so we are calling getMap() here. We don't have an "allowed list" of filters (but we do ignore BackgroundReplacement in Android, for now).
There was a problem hiding this comment.
NM -- i read too much given we're just ignoring BackgroundReplacement.
|
|
||
| ```javascript | ||
| event = { | ||
| text: string, |
There was a problem hiding this comment.
For JS SDK, the caption is returned as caption but for React Native, it's returned as text. Was this intentional?
| @@ -27,6 +27,7 @@ const sanitizeSubscriberEvents = (events) => { | |||
| videoDisableWarning: 'subscriberVideoDisableWarning', | |||
| videoDisableWarningLifted: 'subscriberVideoDisableWarningLifted', | |||
| videoDataReceived: 'subscriberVideoDataReceived', | |||
| captionReceived: 'subscriberCaptionReceived:', | |||
There was a problem hiding this comment.
Looks like a stray colon.
…ments) (#688)
Update modules with npm audit fix
Update react and react native modules
Adding OTPublisher.setVideoTransformers() method
.gitignore android/.gradle files
Typo correction
Correctly Android VideoTransformer() usage
Add live captions API enhancements
Marking some issues resolved in the change log
And other docs edits
Fix subscribeToCaptions typos
Readme correction
Fix registration of subscribeToCaptions event
Fix typos in captionReceived event implementation
Fix OTSubscriber properties -- issue Release 2.25.4 has a coding error in OTSubscriber.js #694 (These were essentially being ignored.)
Docs edit
Set Subscriber captions delegate and listener
docs correction
rev version to 2.26.1
Contributing checklist
Solves issue(s)