Trip sharing #1304
Trip sharing #1304
Conversation
… planned by other
binh-dam-ibigroup
changed the base branch from
dev
to
plan-trip-on-behalf-of
…e I'm a companion.
binh-dam-ibigroup
changed the base branch from
plan-trip-on-behalf-of
to
dev
There was a problem hiding this comment.
Instead of passing the disabled prop so many times, could we use a fieldset and pass it once? https://www.w3schools.com/tags/att_fieldset_disabled.asp
Otherwise code looks good! Just a few suggestions.
| @@ -639,6 +639,10 @@ components: | |||
| tripNotAvailableOnDay: Trip not available on {repeatedDay} | |||
| unsavedChangesExistingTrip: You haven't saved your trip yet. If you leave, changes will be lost. | |||
| unsavedChangesNewTrip: You haven't saved your new trip yet. If you leave, it will be lost. | |||
| TripCompanionsPane: | |||
There was a problem hiding this comment.
I don't think the issue stems from this PR but I am seeing an issue with i18n strings in the wizard when it comes to the travel companion field
There was a problem hiding this comment.
It is indeed a separate issue, see #1331.
There was a problem hiding this comment.
Thoughts on adding an informational alert on this page if it's isReadOnly letting users know why everything is disabled? We can use the Alert component from building blocks. Happy to suggest some language if this is the direction we want to go in
There was a problem hiding this comment.
I do like the idea, looking at a banner that says " has added you to this trip. Therefore, you cannot make changes.". The Alert component in building-blocks is not quite usable for this purpose without restyling it (tricky to import, excess padding/margins even without the icon), so I'll use the react-bootstrap one for the time being.
There was a problem hiding this comment.
@amy-corson-ibigroup Let me know what you think of 5cc84f0.
| if (isReadOnly) { | ||
| return <MonitoredDays days={dayFieldsToArray(monitoredTrip)} /> | ||
| } |
Good catch! Updated in bcba926. |
|
Looks great!! Only nitpick is that the |
Good idea, addressed in 55ed3b7. |
Description
Works with ibi-group/otp-middleware#271, needs #1302.
This PR adds trip sharing in monitored trips: A user saving a trip (whether for themselves or a dependent) can assign confirmed companions as trip companions or observers. Someone assigned as a primary traveler, companion, or dependent has read-only access to the trip (they can view trip details but cannot make changes).
PR Checklist
Screenshot: