Enhanced Stop Viewer Bubbles #469
Conversation
miles-grant-ibigroup
force-pushed
the
enhanced-stop-viewer-bubbles
branch
from
cda8ac5 to
2104b3e
Compare
|
Waiting on #423 to be merged to make this PR cleaner, will then assign. |
|
Waiting for Daniel to get permissions for this repository before doing this. |
|
Regretfully, I don't have a solution to any of the issues you raised -- most crucially the way the caret and bubble widths are related. I tried manually setting values for a second width, but when I tried to find some constant for how they are related, got some strange results: https://www.wolframalpha.com/input/?i=systems+of+equations+calculator&assumption=%7B%22F%22%2C+%22SolveSystemOf2EquationsCalculator%22%2C+%22equation1%22%7D+-%3E%224x%2B3.75x%2B25x%2B68x%3D8%22&assumption=%22FSelect%22+-%3E+%7B%7B%22SolveSystemOf2EquationsCalculator%22%7D%7D&assumption=%7B%22F%22%2C+%22SolveSystemOf2EquationsCalculator%22%2C+%22equation2%22%7D+-%3E%2210x%2B1.5x%2B25x%2B75x%3D-2%22 If you have any ideas please let me know! |
binh-dam-ibigroup
assigned miles-grant-ibigroup and daniel-heppner-ibigroup and unassigned binh-dam-ibigroup
|
I've noticed that if I click somewhere random on the map and open an address popover, then click on the enhanced stop bubble, it opens another address popover for the address behind the bubble rather than the popover for that stop. But if the last thing I clicked was another stop, then I can click anywhere on the enhanced stop bubble and get information for that stop rather than the address behind the bubble.
Also, from a UX perspective, I feel like the map should auto zoom into a stop to the level where you can see the stop viewer bubbles when you click on "Stop Viewer". I have no idea what the context is for this change, so maybe this is totally out of scope. |
…bles-qbd style(EnhancedStopMarker): Tweak calculation of bubble offset
|
Thank you @binh-dam-ibigroup for the PR fix! Merged into this branch. @daniel-heppner-ibigroup that is a very good find thank you! I think the auto-zoom functionality is definitely important, but out of scope for this PR. Have added it to #483 which contains all the things we should fix following the enhanced stop viewer PRs. The issue with reverse geocoding breaking the click behavior is a good catch. It looks like it's also happening with the bike share overlay which to me suggests it's a larger bug not related to this PR. I've created issue #485 which I would close out separately since it looks like this issue wasn't created by this PR. |
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup and daniel-heppner-ibigroup
|
So, @miles-grant-ibigroup, are we not going to try to fix the click behavior issue right now? |
miles-grant-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
|
@daniel-heppner-ibigroup Yes I think the click behavior changes belong in a separate PR. |
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR brings enhanced stop viewer bubbles, "completing" the stop viewer enhancements.
There are some strange things going on with the placement of the caret at the bottom of the bubble. If anyone has an idea of how to improve this, I would greatly appreciate any help there!