feat: verify creds signed with Ed25519VerificationKey2020 #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbluhm
force-pushed
the
feature/ed25519-verification-key-2020
branch
from
1ebab88 to
986d9a3
Compare
|
I would rather be able to do something like this code in the didcomm-messaging-python library: |
|
sorry for my confusion but can't aca-py already do this? |
jamshale
reviewed
Sep 19, 2024
The Ed25519Signature2020 is supported for issuance and verification but only if used with an Ed25519VerificationKey2018, as it turns out. I thought the same before I ran into the problem while doing some interop testing. |
dbluhm
force-pushed
the
feature/ed25519-verification-key-2020
branch
from
155bc95 to
840d3ee
Compare
jamshale
approved these changes
Sep 19, 2024
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
dbluhm
force-pushed
the
feature/ed25519-verification-key-2020
branch
from
840d3ee to
fcad023
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for verifying JSON-LD Credentials using a verification method of type
Ed25519VerificationKey2020.I'm not thrilled about this approach but I think it's the least disruptive change possible right now. Less disruptive seems like a good idea given @PatStLouis work on supporting VC-DI is already underway.
Sidebar, Patrick, hopefully the VC-DI and VCDM 2.0 implementation handles working with verification methods better than the original LDP-VC code does 😅 Working on a verification method that has been framed does not feel right.