Skip to content

Commit

Permalink
🐛 add missing arguments
Browse files Browse the repository at this point in the history
Signed-off-by: ff137 <[email protected]>
  • Loading branch information
ff137 committed Aug 16, 2024
1 parent 6272b1f commit bd11dfe
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -517,10 +517,10 @@ export class ReactNativeAriesAskar implements AriesAskar {
}

public async sessionFetchAll(options: SessionFetchAllOptions) {
const { category, sessionHandle, forUpdate, limit, tagFilter } = serializeArguments(options)
const { category, sessionHandle, forUpdate, limit, orderBy, descending, tagFilter } = serializeArguments(options)
const handle = await this.promisifyWithResponse<string>((cb) =>
this.handleError(
this.ariesAskar.sessionFetchAll({ cb, category, sessionHandle, forUpdate, limit: limit || -1, tagFilter }),
this.ariesAskar.sessionFetchAll({ cb, category, sessionHandle, forUpdate, limit: limit || -1, orderBy, descending, tagFilter }),

Check failure on line 523 in wrappers/javascript/packages/aries-askar-react-native/src/ReactNativeAriesAskar.ts

View workflow job for this annotation

GitHub Actions / Build and test JavaScript wrapper (linux-aarch64)

Replace `·cb,·category,·sessionHandle,·forUpdate,·limit:·limit·||·-1,·orderBy,·descending,·tagFilter` with `⏎··········cb,⏎··········category,⏎··········sessionHandle,⏎··········forUpdate,⏎··········limit:·limit·||·-1,⏎··········orderBy,⏎··········descending,⏎··········tagFilter,⏎·······`

Check failure on line 523 in wrappers/javascript/packages/aries-askar-react-native/src/ReactNativeAriesAskar.ts

View workflow job for this annotation

GitHub Actions / Build and test JavaScript wrapper (darwin-universal)

Replace `·cb,·category,·sessionHandle,·forUpdate,·limit:·limit·||·-1,·orderBy,·descending,·tagFilter` with `⏎··········cb,⏎··········category,⏎··········sessionHandle,⏎··········forUpdate,⏎··········limit:·limit·||·-1,⏎··········orderBy,⏎··········descending,⏎··········tagFilter,⏎·······`
),
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,19 +61,25 @@ export class Session {
category,
forUpdate = false,
limit,
orderBy,
descending = false,
tagFilter,
isJson,
}: {
category: string
tagFilter?: Record<string, unknown>
limit?: number
orderBy?: string,

Check failure on line 72 in wrappers/javascript/packages/aries-askar-shared/src/store/Session.ts

View workflow job for this annotation

GitHub Actions / Build and test JavaScript wrapper (linux-aarch64)

Delete `,`

Check failure on line 72 in wrappers/javascript/packages/aries-askar-shared/src/store/Session.ts

View workflow job for this annotation

GitHub Actions / Build and test JavaScript wrapper (darwin-universal)

Delete `,`
descending: boolean,

Check failure on line 73 in wrappers/javascript/packages/aries-askar-shared/src/store/Session.ts

View workflow job for this annotation

GitHub Actions / Build and test JavaScript wrapper (linux-aarch64)

Delete `,`

Check failure on line 73 in wrappers/javascript/packages/aries-askar-shared/src/store/Session.ts

View workflow job for this annotation

GitHub Actions / Build and test JavaScript wrapper (darwin-universal)

Delete `,`
forUpdate?: boolean
isJson?: boolean
}) {
if (!this.handle) throw AriesAskarError.customError({ message: 'Cannot fetch all from a closed session' })
const handle = await ariesAskar.sessionFetchAll({
forUpdate,
limit,
orderBy,
descending,
tagFilter,
sessionHandle: this.handle,
category,
Expand Down

0 comments on commit bd11dfe

Please sign in to comment.