parse derivatives instead of just relying on tree #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpvc
reviewed
Jul 26, 2023
| @@ -39,7 +39,11 @@ sub Parser::D { | |||
| return (0 * $self)->reduce('0*x' => 1) unless defined $self->{variables}{$x}; | |||
| $f = $f->D($x); | |||
| } | |||
| return $self->new($f); | |||
| my $deriv = $self->new($f); | |||
| $deriv->{string} = $deriv->{tree}->string; | |||
There was a problem hiding this comment.
This line means that any constants are clipped to 6 significant digits (the default number format), so the result may have different from the original.
You may also want to add a new reduction rule that controls doing this doing this, so it can be turned off, if desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking derivatives using the
Dmethod ends up creating formulas that refuse to reduce (e.g. constant products appearing in the derivative of a polynomial).This PR modifies the behavior of the
Dmethod -- preserving the existing tree structure of the derivative, but now processing the result of that process (respecting the existing context flags for free).