Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fix remote configuration getting stored if backup not available #153 #154

Merged
merged 5 commits into from
Dec 15, 2021
Merged

[fix] Fix remote configuration getting stored if backup not available #153 #154

merged 5 commits into from
Dec 15, 2021

Conversation

devkapilbansal
Copy link
Member

@devkapilbansal devkapilbansal commented Nov 24, 2021 •
edited
Loading

Store only when configuration is not in remote

Close #153

@devkapilbansal devkapilbansal changed the title [refactor] Use stored dir for storing configuration and minor changes… [refactor] Use stored dir for storing configuration and minor changes #153 Nov 24, 2021
@devkapilbansal devkapilbansal force-pushed the issues/153-fix-configuration branch from ecf7f10 to 668de1d Compare November 24, 2021 20:57
@devkapilbansal devkapilbansal changed the title [refactor] Use stored dir for storing configuration and minor changes #153 [fix] Use stored dir for storing configuration and minor changes #153 Nov 24, 2021
@devkapilbansal devkapilbansal force-pushed the issues/153-fix-configuration branch 2 times, most recently from 9fcce90 to 10f0740 Compare November 24, 2021 21:35
@devkapilbansal devkapilbansal marked this pull request as ready for review November 24, 2021 21:36
@okraits okraits mentioned this pull request Nov 26, 2021
Closed
@devkapilbansal devkapilbansal force-pushed the issues/153-fix-configuration branch 2 times, most recently from 194a380 to dec1ed0 Compare November 29, 2021 22:30
@devkapilbansal devkapilbansal changed the title [fix] Use stored dir for storing configuration and minor changes #153 [fix] Fix remote configuration getting stored if backup not available #153 Nov 29, 2021
@devkapilbansal devkapilbansal force-pushed the issues/153-fix-configuration branch from 0d15300 to fe2bc14 Compare December 2, 2021 15:37
@devkapilbansal devkapilbansal force-pushed the issues/153-fix-configuration branch from fe2bc14 to 9f02107 Compare December 3, 2021 22:38
@devkapilbansal
Copy link
Member Author

I just rebased the branch

nemesifier
nemesifier approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okraits @devkapilbansal I did some testing to verify the bug that I was having is not there anymore.

Please @okraits can you do a manual test of your original use case to ensure it's still working good for you (the backup of the original conf)?

@nemesifier nemesifier merged commit 4b71766 into master Dec 15, 2021
@nemesifier nemesifier deleted the issues/153-fix-configuration branch December 15, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okraits okraits okraits left review comments

@nemesifier nemesifier nemesifier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Removal of configurations was affected negatively by recent change
3 participants
@devkapilbansal @nemesifier @okraits