-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basicstation, sx1302_hal: initial commit #19188
Conversation
ping @aparcar |
c44163e
to
a069236
Compare
Looks excellent to me, amazing first time contribution! I don't have hardware at hand to test this, do you have a recommendation? That's not a blocker for this PR but I'm keen to test it on real hardware. |
Thank you for your feedback! I have selected the n-fuse LRWCC3-MPCI concentrator card for testing. It is based on the SX1303 chip from Semtech and most importantly, it is in stock right now. In my opinion, you can choose any end-devices, as Class-A support is mandatory. |
Hi there, I have an older MTCDT with an SPI-based SX1302 in it which I'm working on standing OpenWrt onto. Is there a reason you're not providing SPI support in this package -- is it a matter of basicstation configuration? |
a069236
to
3364942
Compare
Hi @Hurricos, at the moment i don't have suitable hardware to test SPI-based devices. Maybe you could add SPI support in future versions since you have the necessary hardware. If so, I could review your contribution. |
3364942
to
40ac8c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about adding test.file
to be run tested inside CI to check versioning and if it works?
bf8ead1
to
3a8fb34
Compare
I saw the test.sh file you authored at 2199234 and adopted it to this package. Is it OK like that? |
Seems good for basicstation. See output in test build:
|
1412f1b
to
cec80b4
Compare
cec80b4
to
922fff4
Compare
922fff4
to
59b12fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from one thing, Makefiles looks good! Test files were added. Much appreciated. Patches were submitted to upstream repositories for review. I am satisfied. 😊
The SX1302 hardware abstraction layer is required by the basicstation to control the concentrator based on SX1302/SX1303 chip. Signed-off-by: Marcus Schref <[email protected]>
(LoRa) Basicstation is an implementation of a LoRa packet forwarder and is intended to be run on the host of a LoRa-based gateway. Basicstation forwards RF packets recieved by a concentrator to a LoRaWAN network server (LNS). It also transmits RF packets received from the LNS to one or multiple LoRa end devices. Further information: https://lora-developers.semtech.com/build/ software/lora-basics/lora-basics-for-gateways Signed-off-by: Marcus Schref <[email protected]>
59b12fb
to
b7d4660
Compare
Glad to hear that! I replaced the installation macro, so it should be fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing was addressed and my last comment still stands. :)
Well then let's try it |
Maintainer: me
Compile tested: x86_64, lantiq_xrx200, latest openwrt-21.02, latest openwrt-22.03
Run tested: x86_64, lanitq_xrx200, latest openwrt-21.02, latest openwrt-22.03
Description:
(LoRa) Basicstation is an implementation of a LoRa packet forwarder and is intended to be run on the host of a LoRa-based gateway. Basicstation forwards RF packets recieved by a concentrator to a LoRaWAN network server (LNS). It also transmits RF packets received from the LNS to one or multiple LoRa end devices.
Further information: https://lora-developers.semtech.com/build/software/lora-basics/lora-basics-for-gateways
The SX1302 hardware abstraction layer is required by the basicstation to control the concentrator based on SX1302/SX1303 chip.
Testing:
Several Class-A end devices from different manufactures were used. TTN and ChirpStack were tested as LNS servers. The concentrator card used is based on Semtech's SX1302/SX1303 corecell reference design and does not have GPS. Currently only concentrator cards with USB interface are supported. (no SPI support)
Inspired by lora-feed from @xueliu
Signed-off-by: Marcus Schref [email protected]