Python bootstrap #182
Merged
Python bootstrap #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
- move to hatch instead of setuptools - Python 3.11 - upgrade dependencies - re-arrange Dockerfile to optimize image / build time - many small code adaptations linked to issues raised by linter or type checker - rework CI/CD workflows - add dummy test to open the road to many more
JQuery Chosen is deprecated and forces us to stay on JQuery 1 ogv.js has not been updated
benoit74
force-pushed
the
python_bootstrap
branch
from
19cc820 to
fbd9748
Compare
|
I just uploaded https://dev.library.kiwix.org/viewer#badminton_webm_2023-10/home.html which has been created by this new code. I would like to test this on IE11 / old Safari to ensure there is no regression since I updated the webp polyfill, but I probably do not have it at home. |
Added |
rgaudin
requested changes
Oct 18, 2023
- Simplify Youtube class to get rid of typing issues - Small fixes
rgaudin
requested changes
Oct 19, 2023
|
I think I've provided feedback on remaining points. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #180
Changes:
load_mandatory_jsonutil function which raises an error if file is not present or JSON is not valid (instead of returning None)render_templateutil function which returns a string or returns an error (to circumvent various types returned by Jinja)