Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #192: Update default publisher to 'openZIM' #196

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

nida-imran173
Copy link
Contributor

@nida-imran173 nida-imran173 commented Mar 13, 2024

Description

This pull request resolves the issue by updating the default publisher from "Kiwix" to "openZIM".

Changes Made

  • Updated the default publisher value to "openZIM".

Fixes #192

@nida-imran173
Copy link
Contributor Author

fixes #192

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.83%. Comparing base (26f5c71) to head (c677b48).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #196   +/-   ##
=====================================
  Coverage   1.82%   1.83%           
=====================================
  Files         10      10           
  Lines        929     928    -1     
  Branches     147     147           
=====================================
  Hits          17      17           
+ Misses       912     911    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good, thank you. Just one more thing I forgot in previous review (because I also tend to forget to do it myself, but let's try to give you good habits): we need to update the Changelog. Add an entry in the ## [Unreleased] section (not in a version section, we will assign a version to this change during the release process). See https://github.com/openzim/ted/pull/165/files for a good example.

@nida-imran173 nida-imran173 requested a review from benoit74 March 14, 2024 10:14
@benoit74 benoit74 merged commit 7df7c9e into openzim:main Mar 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonize default publisher to openZIM
2 participants