Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout of Videos tab in zimui to display videos from all playlists in the ZIM #349

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

dan-niles
Copy link
Collaborator

Fix #337

Update layout of Videos tab in zimui to display videos from all playlists in the ZIM. The videos from each playlist are now listed in separate rows as carousels.

Screenshots:
image

image

@dan-niles dan-niles self-assigned this Oct 7, 2024
@dan-niles dan-niles marked this pull request as draft October 7, 2024 11:17
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 1.50%. Comparing base (cde86e3) to head (c7639c4).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/youtube2zim/scraper.py 0.00% 9 Missing ⚠️
scraper/src/youtube2zim/schemas.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #349      +/-   ##
========================================
- Coverage   1.51%   1.50%   -0.02%     
========================================
  Files         11      11              
  Lines       1119    1128       +9     
  Branches     170     170              
========================================
  Hits          17      17              
- Misses      1102    1111       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan-niles dan-niles marked this pull request as ready for review October 7, 2024 11:19
@dan-niles dan-niles requested a review from benoit74 October 7, 2024 11:20
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work, thanks a lot!

I do not have much to say, it looks like you spend quite a lot of time testing this and it is working very well.

My only concern is about the two tabs we have on the main page. I'm not sure they are really useful anymore. But I will open a dedicated issue on that, since this needs to be answered by more people than the two of us, and having ZIMs to showcase the situation is probably going to help.

I will rebase and merge right away.

@benoit74 benoit74 force-pushed the new-landing-page-ui branch from e7dadbd to c7639c4 Compare October 8, 2024 07:44
@benoit74 benoit74 merged commit e1a0f2b into main Oct 8, 2024
10 checks passed
@benoit74 benoit74 deleted the new-landing-page-ui branch October 8, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI is not always really relevant when many playlists are in the ZIM
2 participants