Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always reencode using our presets (even for high quality) and choose best format #373

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Oct 31, 2024

Fix #356

Changes

  • simplify choosing best format from youtube to be sure to have a format with highest resolution possible in all cases to avoid problems while re-encoding
  • always reencode (even for high quality) using our presets, to simplify things (otherwise it is too much dependent on Youtube choices in terms of resolution and codecs and bitrates, hard to follow)

@benoit74 benoit74 self-assigned this Oct 31, 2024
@benoit74 benoit74 force-pushed the format_simplified branch 2 times, most recently from ec72c49 to f359842 Compare October 31, 2024 15:05
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 1.25%. Comparing base (b4ec53f) to head (92976e5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/youtube2zim/scraper.py 0.00% 5 Missing ⚠️
scraper/src/youtube2zim/processing.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #373   +/-   ##
=====================================
  Coverage   1.25%   1.25%           
=====================================
  Files         11      11           
  Lines       1114    1114           
  Branches     163     163           
=====================================
  Hits          14      14           
  Misses      1100    1100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review October 31, 2024 16:02
@benoit74 benoit74 requested a review from rgaudin October 31, 2024 16:03
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM<

Base automatically changed from drop_type_arg to main November 1, 2024 13:18
@benoit74 benoit74 merged commit 95ad5bc into main Nov 1, 2024
10 checks passed
@benoit74 benoit74 deleted the format_simplified branch November 1, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose proper format to download youtube videos
2 participants